search

opengridcc / opengrid-dev

Open source building monitoring, analysis and control
Apache License 2.0
26 stars 21 forks source link

issue94 analysis class #111

Closed saroele closed 8 years ago

saroele commented 8 years ago

I wanted to add this commit to the pull request #110 but I did it wrong and it became a separate PR.

@JrtPec , I didn't change anything fundamental. Main changes are a separate do_analysis() method that gives more flexibility and a unittest. I adapted the notebooks demo_cache and electricity_standby to the new framework.

(@Ryton ) The notebook Electricity_standby.ipynb contains a function to filter out the submeters. If this function is fine, we should move it to the library. Atm, the function prints out a lot of debug info, so you can see which sensors are removed.

JrtPec commented 8 years ago

Looks great! What do you propose: merge #111 and drop #109 and #110 ?

saroele commented 8 years ago

Yes. As I it contains all your commits, I think that merging that pr will close the others. Op 25 feb. 2016 23:35 schreef "Jan Pecinovsky" notifications@github.com:

Looks great! What do you propose: merge #111 https://github.com/opengridcc/opengrid/pull/111 and drop #109 https://github.com/opengridcc/opengrid/pull/109 and #110 https://github.com/opengridcc/opengrid/pull/110 ?

— Reply to this email directly or view it on GitHub https://github.com/opengridcc/opengrid/pull/111#issuecomment-189014704.

Ryton commented 8 years ago

@saroele Sounds good! I'll look into it this afternoon