search

opengridcc / opengrid-dev

Open source building monitoring, analysis and control
Apache License 2.0
26 stars 21 forks source link

'Smart main' not synced #152

Open Ryton opened 7 years ago

Ryton commented 7 years ago

Some OG-res (open grid respondents :P) also gave (or only gave) their smart main sensors and token.

For example: FL03001579 However, the smart-main series are not synced trough tmpo.

Can this be resolved, either by replacing the smart main data with the non-smart sensor data, or updating all 'smart main' ID-s and tokens from the houseprint?

saroele commented 7 years ago

You have hit a nail :-) We have to solve these default smart sensors. They often don't contain any data.

I think it's a good idea to try to sync data for any sensor that has been configured by an OG-res, but when no data is available, there should be no processing and no link on the website.

On Wed, Oct 26, 2016 at 11:23 AM, J. Ver. notifications@github.com wrote:

Some OG-res (open grid respondents :P) also gave (or only gave) their smart main sensors and token.

For example: FL03001579 However, the smart-main series are not synced trough tmpo.

Can this be resolved, either by replacing the smart main data with the non-smart sensor data, or updating all 'smart main' ID-s and tokens from the houseprint?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/opengridcc/opengrid/issues/152, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiVBpVmFc9cD0XkzSnDvcrktv58fYB7ks5q3xwogaJpZM4Kg8Vu .

JrtPec commented 7 years ago

I have added a property for the fluksosensor to check if it has data or not, we could use that to filter views

saroele commented 7 years ago

I think we have this this issue in #166.
Before applying a quick change, we should write a unittest.

JrtPec commented 7 years ago

We would have to mock a sensor in tmpo...

Something like:

hp.tmpos.add('mock', 'mock')
...
# do not sync tmpos because it will fail with false sensor info
test_sensor = FluksoSensor('mock', ...)
assertFalse(test_sensor.has_data)
hp.tmpos.delete('mock', 'mock')
saroele commented 7 years ago

I think we should only use mocks in the tests.

On Mon, Nov 28, 2016 at 10:47 AM, Jan Pecinovsky notifications@github.com wrote:

We would have to mock a sensor in tmpo...

Something like:

hp.tmpos.add('mock', 'mock')...# do not sync tmpos because it will fail with false sensor info test_sensor = FluksoSensor('mock', ...) assertFalse(test_sensor.has_data) hp.tmpos.delete('mock', 'mock')

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/opengridcc/opengrid/issues/152#issuecomment-263226947, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiVBjr5jYhPzLiXLci4eNYUzn7N9-6Zks5rCqMVgaJpZM4Kg8Vu .

JrtPec commented 7 years ago

Sure, we could do this in the mock houseprint object that we use in the tests somewhere