opengridcc / opengrid-dev

Open source building monitoring, analysis and control
Apache License 2.0
26 stars 21 forks source link

sync tmpos with error handling #157

Closed JrtPec closed 7 years ago

JrtPec commented 7 years ago

This pull requires some updates to TMPO first: flukso/tmpo-py#17 and flukso/tmpo-py#19.

Long story short:

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 70.393% when pulling fdf4c51d89569abd732daef7a4cc0c5c3de89513 on JrtPec:ignore-tmpo-sync-errors into 167982b28476eaceb5e3e809f60333fa4015fed5 on opengridcc:develop.

saroele commented 7 years ago

Well done, I can confirm that this works. I got stuck on the JSONDecodeError tonight and tried your pull request. As you said, I updated the tmpo-py first.

Let's try once more to push the changes to tmpo-py upstream so we avoid creating forks. @icarus75 can you take care of the pull requests, mainly flukso/tmpo-py#17 and flukso/tmpo-py#19.

icarus75 commented 7 years ago

@saroele @JrtPec Thanks for the heads-up. PR #15,16,17 & 19 have been merged into tmpo-py master. An updated package (0.2.3) has been pushed to Pypi. Let me know if there are any issues with this latest version.