Correct monthly sampling in Energy_signature.ipynb

opengridcc / opengrid-dev

Open source building monitoring, analysis and control

Apache License 2.0

26 stars 21 forks source link

Correct monthly sampling in Energy_signature.ipynb #176

Closed saroele closed 7 years ago

saroele commented 7 years ago

@JrtPec I found a major bug in the Energy_signature notebook and tested different ways of solving it. Please have a look at the different generators.

I'm in favour of using the 4th and even improving it so it doesn't bug when we put diff=True because of the unit conversion. Therefore, I created a milestone: https://github.com/opengridcc/opengrid/milestone/4 to group a few improvements. #173 is handled in this commit, others to be tackled.

coveralls commented 7 years ago

Coverage decreased (-0.05%) to 70.088% when pulling 302522b6d368df9a483d0bdaf639c1f06a2cd5e7 on saroele:issue172_multivarregression into ccf995a7a10f937f6461077560eda681fc863403 on opengridcc:develop.

saroele commented 7 years ago

@JrtPec bump I'll continue developing in this branch for now. Can you check out the bugs I solved and the solution I propose? Tnx

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 69.446% when pulling 299323811f1a71ad12efa22422e9f509a998071f on saroele:issue172_multivarregression into f059fdd3f3ef684ae3f80cc68745a9c8bad400c2 on opengridcc:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 69.446% when pulling 35de4a7ae1617d25c0dceae318f318aa54c2d14f on saroele:issue172_multivarregression into f059fdd3f3ef684ae3f80cc68745a9c8bad400c2 on opengridcc:develop.

saroele commented 7 years ago

I propose to merge this branch. The multi-variable regression will still evolve and improve a lot, but no need to keep it separated from the develop branch.

coveralls commented 7 years ago

Coverage decreased (-0.05%) to 69.446% when pulling cf9e81c0cfff1d16d185b277d2bdb1ba7c8f8b21 on saroele:issue172_multivarregression into 3165cdab2d1d5e36317b2a86e5d4a9860ed920d4 on opengridcc:develop.