search

opengridcc / opengrid-dev

Open source building monitoring, analysis and control
Apache License 2.0
26 stars 21 forks source link

New houseprint #63

Closed JrtPec closed 8 years ago

saroele commented 9 years ago

Jan, I pulled your branch and solved the conflict (was only in the .gitignore). I have already successfully ran the New Houseprint.ipynb notebook. I want to merge it quickly in the mail develop branch, but I will first go to all the notebooks and make sure the conversion is fine.

I think we should have a unittest for this new module. I will start writing it but I'll push the develop branch first so everybody can start using this new houseprint api.

I'll keep you posted, Roel

JrtPec commented 8 years ago

It would be nice if you could set up the unit test environment and write some examples, since I have no experience with unit tests. Once I can see how it's done I will see if I can help out.

saroele commented 8 years ago

ok, I'll do that, can take a few days though.

saroele commented 8 years ago

@JrtPec I created a copy of the houseprint reponses for the unit and integration tests. But even after sharing it with opengridcc@gmail.com I'm unable to load this with gspread. The error is a 'Spreadsheet not found' error.

I supposed the json key was for opengridcc@gmail.com, but maybe it's for another account? Or do you have any idea why it's not working? You can test if it works by adding spreadsheet='unit and integration test houseprint' to the initialization call for the Houseprint object.

JrtPec commented 8 years ago

You have to share the spreadsheet with te e-mailadres that is specified in the OAuth JSON :-)

On Tue, Sep 22, 2015 at 10:10 PM, saroele notifications@github.com wrote:

@JrtPec I created a copy of the houseprint reponses for the unit and integration tests. But even after sharing it with opengridcc@gmail.com I'm unable to load this with gspread. The error is a 'Spreadsheet not found' error.
I supposed the json key was for opengridcc@gmail.com, but maybe it's for another account? Or do you have any idea why it's not working?

You can test if it works by adding spreadsheet='unit and integration test houseprint' to the initialization call for the Houseprint object.

Reply to this email directly or view it on GitHub: https://github.com/opengridcc/opengrid/pull/63#issuecomment-142404916

saroele commented 8 years ago

hehe, indeed ;-) thanks, works now. I can move on!

saroele commented 8 years ago

unit (and integration) test for houseprint is well advanced. I want to change the houseprint api a bit, i'll do that in a separate branch