search

opengridcc / opengrid-dev

Open source building monitoring, analysis and control
Apache License 2.0
26 stars 21 forks source link

optional and variable heating and cooling degree days #68

Closed JrtPec closed 8 years ago

JrtPec commented 8 years ago

Static heating and cooling degree days were removed and replaced by boolean flags and arguments to set your own base temperatures. Default turns on only heating degree days on a base temperature of 16.5°C

saroele commented 8 years ago

Nice, check ik morgen!

On Wed, Oct 21, 2015 at 5:51 PM, Jan Pecinovsky notifications@github.com wrote:

Static heating and cooling degree days were removed and replaced by boolean flags and arguments to set your own base temperatures. Default

turns on only heating degree days on a base temperature of 16.5°C

You can view, comment on, or merge this pull request online at:

https://github.com/opengridcc/opengrid/pull/68 Commit Summary

  • optional and variable heating and cooling degree days

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/opengridcc/opengrid/pull/68.

saroele commented 8 years ago

Hi @JrtPec Great improvements. I did one big change, that's very important after all: never pass functions to be evaluated as default arguments. See also http://lgiordani.com/blog/2015/02/11/default-arguments-in-python/#.VilR85Oli1E (section Default arguments evaluation). This is really a python-quirk that you have to know. I always pass None as defaults (no empty modifiable objects, that's also dangerous).

JrtPec commented 8 years ago

@saroele somehow I have the feeling I've read this article before... anyhow, thanks for the corrections!