search

opengridcc / website

1 stars 10 forks source link

Include Fork me on GitHub banner #29

Closed kdebrab closed 8 years ago

kdebrab commented 8 years ago

with link to opengridcc/opengrid repository

JrtPec commented 8 years ago

Merged #41

JrtPec commented 8 years ago

I'm reopening this issue because I noticed that when you display the website on a smaller screen, the navbar collapses into a single button in the top right, which you cannot click because the banner is laid over it. I can try putting a banner in the top left corner, but if that impedes some functionality I'm out of ideas.

rubenbaetens commented 8 years ago

Can't you force to get the single button top-left next to the logo when shown on smaller screens ?

JrtPec commented 8 years ago

Probably. Perhaps someone with some more knowledge on CSS and Bootstrap could weigh in on this.

GMathyssen commented 8 years ago

I will look into it

JrtPec commented 8 years ago

Additional bug I noticed: The flash messages have this little x button which you can use to close the div, but right now the button is hidden under the banner. (It doesn't look like it, but you can't click it).

GMathyssen commented 8 years ago

I can make the fork banner jump to the left (of right, but not so ideal for mobile) bottom corner of the page for mobile. Or maybe just move the thing there definitely?

JrtPec commented 8 years ago

Moving it to the bottom might solve all problems...

GMathyssen commented 8 years ago

I don't get the flash messages? Or not for the website that's now on-line...

JrtPec commented 8 years ago

Since we removed the separate sensor pages last Tuesday there are no more 'graph not found' errors... Try forcing a 404 error, that should display one too: go to www.opengrid.be/blablabla

GMathyssen commented 8 years ago

It is moved to the bottom left corner as a test. Feel free to give any comment

JrtPec commented 8 years ago

Fixed the link to the image, should have been static/images/...

It appears on the bottom left, but it appears at the bottom of the page, while it should be sticking to the bottom of the screen. Probably something to do with relative vs. absolute. Perhaps this screenshot clarifies things: screen shot 2016-02-12 at 00 14 39

JrtPec commented 8 years ago

This is when I resized the page. I think the banner ought to be moving up with the window. screen shot 2016-02-12 at 00 21 59

GMathyssen commented 8 years ago

True, on it

GMathyssen commented 8 years ago

This might do the trick. Sorry that I can't test it myself, working on that!

JrtPec commented 8 years ago

It still looks the same...

GMathyssen commented 8 years ago

Banner in the left bottom wasn't so good for mobile, so I did the original idea: banner in top right, and for mobile just a button in the navbar.

JrtPec commented 8 years ago

Looks great! Tested on iPhone, looks great too. One issue: the banner collapses into the navbar, but the span remains on top of the menu button. See screenshot. screen shot 2016-02-15 at 21 10 16

saroele commented 8 years ago

ja gert, Jan is je wel tot het uiterste aan het drijven :)

On Mon, Feb 15, 2016 at 9:12 PM, Jan Pecinovsky notifications@github.com wrote:

Looks great! Tested on iPhone, looks great too. One issue: the banner collapses into the navbar, but the span remains on top of the menu button. See screenshot. [image: screen shot 2016-02-15 at 21 10 16] https://cloud.githubusercontent.com/assets/4570408/13059174/b2bf1eae-d428-11e5-8bbd-7792e50f7ebd.png

— Reply to this email directly or view it on GitHub https://github.com/opengridcc/website/issues/29#issuecomment-184368993.

GMathyssen commented 8 years ago

:) Mja, my mistake, I just have to test my work better. It is fixed!

JrtPec commented 8 years ago

:+1: