Add support for Condition to Java Rules - Bug Fixes

openhab-scripters / openhab-helper-libraries

Scripts and modules for use with openHAB

Eclipse Public License 1.0

88 stars 70 forks source link

Add support for Condition to Java Rules - Bug Fixes #219

Closed volfan6415 closed 4 years ago

volfan6415 commented 5 years ago

Update rules.js … fix two bugs with new Simple Rule object creation

add support for adding conditions to rule defintions

Conditions.js

this simplifies the code for ItemStateCondition as well as fixes an error where generic compare condition would not create valid condition types

5iver commented 4 years ago

@volfan6415, sorry for the delay... my time has been very limited. Could you please split this PR into two... one for rules.js and one for conditions.js?

volfan6415 commented 4 years ago

Done. Created 286 and 287 this pull can be closed.

I broke the split based on functionality vs the files. There were changes in rules.js which need to be made for the conditions to work properly.

5iver commented 4 years ago

Thank you!