search

openhab-scripters / openhab-helper-libraries

Scripts and modules for use with openHAB
Eclipse Public License 1.0
88 stars 69 forks source link

UpdateActions.rst to reflect 2.x mail binding action #281

Closed vzorglub closed 4 years ago

vzorglub commented 4 years ago

UpdateActions.str to reflect new mail binding action Signed-off-by: Vincent Regaud vzorglub@gmail.com

5iver commented 4 years ago

This gets frustrating... but you're learning something new! You added the sign-off into the body of the PR but not into the commit message, which gets stored with the commit and is used to identify the commiter. :slightly_frowning_face:

Let me know before you run off in frustration, because I can do some magic behind the scenes. I'd rather not though, since it is a good learning experience.

vzorglub commented 4 years ago

Do it, I think GitHub is great but I cannot get my head around how it works I have tried before and it’s just a maze of unnecessary complications

And don’t get me started on trying to use it locally... That is black magic I just don’t get it

From: Scott Rushworth Sent: 08 November 2019 22:59 To: openhab-scripters/openhab-helper-libraries Cc: vzorglub; Author Subject: Re: [openhab-scripters/openhab-helper-libraries] UpdateActions.rst toreflect 2.x mail binding action (#281)

This gets frustrating... but you're learning something new! You added the sign-off into the body of the PR but not into the commit message, which gets stored with the commit and is used to identify the commiter. 🙁 Let me know before you run off in frustration, because I can do some magic behind the scenes. I'd rather not though, since it is a good learning experience. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

vzorglub commented 4 years ago

You added the sign-off into the body of the PR but not into the commit message, which gets stored with the commit and is used to identify the commiter.

Next time hopefully

From: Scott Rushworth Sent: 08 November 2019 22:59 To: openhab-scripters/openhab-helper-libraries Cc: vzorglub; Author Subject: Re: [openhab-scripters/openhab-helper-libraries] UpdateActions.rst toreflect 2.x mail binding action (#281)

This gets frustrating... but you're learning something new! You added the sign-off into the body of the PR but not into the commit message, which gets stored with the commit and is used to identify the commiter. 🙁 Let me know before you run off in frustration, because I can do some magic behind the scenes. I'd rather not though, since it is a good learning experience. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

rkoshak commented 4 years ago

And don’t get me started on trying to use it locally... That is black magic I just don’t get it

I've actually found that working through VSCode is more self explanatory and intuitive. I wrote up a reply to a thread on the forum somewhere...

https://community.openhab.org/t/dco-check-signing-off-with-github-web-editor-explanation/83330/6

Maybe this will make the workflow a little easier on you. I know it has for me.