[Area Triggers and Actions] Refactor light_action

openhab-scripters / openhab-helper-libraries

Scripts and modules for use with openHAB

Eclipse Public License 1.0

88 stars 69 forks source link

[Area Triggers and Actions] Refactor light_action #324

Closed theiding closed 3 years ago

theiding commented 4 years ago

The existing light_action code duplicates code for brightness > 0 and brightness == 0 handling and across the dimmer, switch and color handling. Collapsing the code will make it more readable and extensible, which will be helpful for users as light_action is meant to be customized by users.

theiding commented 4 years ago

I have the code available and am happy to submit the PR.

5iver commented 3 years ago

Resolved in #361.