openhab-scripters / openhab-helper-libraries

Scripts and modules for use with openHAB
Eclipse Public License 1.0
88 stars 70 forks source link

Restructure repo to improve collaboration #41

Closed 5iver closed 5 years ago

5iver commented 5 years ago

Everyone please review and test. I won't merge until there is some positive feedback. This PR has some major changes, which hopefully everyone will be supportive of. All documentation has also been updated to reflect these changes.

mjcumming commented 5 years ago

I have tested the metadata and item create portions. They are working. I have completely implemented the metadata usage in my project. I cannot use the item create routinely until the group events are fixed.

Scott, where do you envision support code going, ie if we do a class to manage metadata? Under lib/python? How do you envision sharing a code that others might want to reuse - is there a way to redistribute it?

Overall, Jython has been incredible. Thank you for your work on this.

5iver commented 5 years ago

Scott, where do you envision support code going, ie if we do a class to manage metadata? Under lib/python?

A module should do it, but a component script may work too. Rereading everything again was eye opening. There is a whole lot of stuff I've still not really explored. Off the top of my head, I'd probably say a utils module. I use one in my setup, but A lot of it could go into core modules.

I haven't been able to focus on this one... give me a few days, and I'll get back to you.

How do you envision sharing a code that others might want to reuse - is there a way to redistribute it?

I'm not exactly sure what you are asking here.

mjcumming commented 5 years ago

For code sharing.... wondering how to make it easier over a cut and paste method or more complex like using pip?

smar000 commented 5 years ago

For code sharing.... wondering how to make it easier over a cut and paste method or more complex like using pip?

In an ideal world, maybe something in PaperUI where users can see details on each available module, and then click to download/install as required?

5iver commented 5 years ago

In an ideal world, maybe something in PaperUI where users can see details on each available module, and then click to download/install as required?

I could imagine there's a possibility that an OH binding that would install and setup JSR223-Jython with the core package could make it into the distribution. It is much more likely that it would need to come from the Eclipse Marketplace though, especially anything from the community package.

Pip would be interesting, especially for resolving dependencies, but it lacks the simplicity of a browser interface and integration with Paper UI.

5iver commented 5 years ago

OK, I've been testing this for a while now without issues, and just did another polishing of the docs. I think it's ready to merge! Please speak up now if you have any issues or concerns to be addressed.

andiwirs commented 5 years ago

working fine for me so far :)