search

openhab / jamod

A fork of Java Modbus Library (jamod) - http://jamod.sourceforge.net/
Apache License 2.0
18 stars 25 forks source link

Remove stacktrace print and reduce logging severity level #4

Closed ssalonen closed 4 years ago

ssalonen commented 4 years ago

Connection and I/O errors were printed out to stdout. Now removed to clean out the output.

Also many logging statements very tuned to be less loud, as the errors are handled in the transport bundle.

cc @kaikreuzer

I'm not sure how the release of this bundle really goes, hope you can execute the needed steps.

Signed-off-by: Sami Salonen ssalonen@gmail.com

kaikreuzer commented 4 years ago

Thanks @ssalonen - I have just published a new release of the lib to bintray: https://bintray.com/openhab/mvn/jamod/1.2.4.OH

ssalonen commented 4 years ago

Thanks! Will it end up in openHAB 2/3 release at some point?

kaikreuzer commented 4 years ago

I would say it will end up there once you create a PR, which changes this line: https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.io.transport.modbus/pom.xml#L30