openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.87k stars 3.58k forks source link

Resol binding in version 3.1 M4 not updating values #10684

Closed EjvindHald closed 3 years ago

EjvindHald commented 3 years ago

I am using the OH version 3.1 M4 where the new Resol binding has been included.

I have configured everything using files, and the connection is fine.

Upon startup of OH all the temperatures and pump measures are updated and show correct values.

However, these values seem to be static - they are not updated as they change in my KM2 device.

If I restart the binding using Karaf console I get an one time update of the values.

I saw similar behaviour in the Resol binding for OH version 2.x, if the binding was activated using the addons folder instead of Market Place.

My installation is Linux Ubunto.

openhab-bot commented 3 years ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/resol-binding-stopped-working-in-recent-nightly-builds/122371/2

openhab-bot commented 3 years ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/resol-binding-stopped-working-in-recent-nightly-builds/122371/3

ramack commented 3 years ago

This seems to be fixed in the meantime, probably by some change in core with the UnitsOfMeasurement. The resol binding emits l/h which doesn't seem to be a known unit in class org.openhab.core.library.unit.Units

Is this an issue in the binding and it should convert the data into l/min, or should the l/h be added in the core?

ramack commented 3 years ago

BTW the binding just forwards the unit in a string from the used vbus-java library, so potentially there might come up another unit which is not known in core. While some unit symbols ("%RH", "Ω") are already handled specially in ResolThingHandler.java:packetReceived() other devices (which was not yet tested) might uses new unit strings for which we might need to add a special handling, too.

ramack commented 3 years ago

RP for for the bugfix for this issue is ready for review!