openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.88k stars 3.59k forks source link

[jeelink] Discovery documentation does not mention the need to scan for sensors. #11986

Closed cmorty closed 2 years ago

cmorty commented 2 years ago

The Documentation says that new sensors should show up in my inbox. However, it seems I need to scan for sensors as explained in the forum.

Is the documentation wrong? Or does this only apply to lacrosse? Or is this a bug or missing feature?

If I get some input, I'm willing to update the documentation.

lolodomo commented 2 years ago

Some bindings are implementing an automatic discovery, some are not. With the second category, the user has to trigger a search in MainUI. Mentioning in the documentation whether the discovery is automatic or not would be an appreciated bonus, but I don't consider it as a bug if the information is missing, simply because the documentation of a particular binding is not a guide on how discovery is generally working in openHAB.

cmorty commented 2 years ago

@lolodomo The issue I have, is that the way the documentation is written suggests that JeeLink supports automatic discovery (IMO).

lolodomo commented 2 years ago

You can propose a change.

I have not checked the code. @vbier : please confirm whether or not the discovery is automatic.

vbier commented 2 years ago

Discovery needs to triggered manually. Docs do not mention autodiscovery, afaics.

lolodomo commented 2 years ago

Discovery needs to triggered manually. Docs do not mention autodiscovery, afaics.

I agree with you, I see no mention of automatic discovery in the documentation. @cmorty : the documentation is just correct.

cmorty commented 2 years ago

@vbier @lolodomo To me (I'm a noob to OH), this sounds like I just need to add the Gateway and my sensors will automatically show up in my inbox:

Afterwards, discovery reads from the USB receiver / LaCrosseGateways to find out which sensors are currently connected. It then creates a thing for every unknown sensor and puts it in the Inbox.

Or does it mean, that discovery is automatically run after the creation?

With the knowledge I have now, I might have guessed reading the next paragraph:

[...] In rare cases, a second discovery run is needed.

If nobody minds I'd try to change the wording a bit and try make it easier to understand to non-experts.

lolodomo commented 2 years ago

discovery does not mean automatic discovery. You could enhance something like that if you like: Afterwards, when you run it, discovery reads from the