search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.58k forks source link

Homematic Binding: Several messages regarding not found descriptions #1330

Closed MHerbst closed 7 years ago

MHerbst commented 7 years ago

When starting openHAB I get several messages because of missing descriptions:

2016-10-15 22:51:45.046 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.046 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.047 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.047 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.047 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.047 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|ERROR|, ERROR|, 2016-10-15 22:51:45.047 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: SHUTTER_CONTACT|STATE, STATE 2016-10-15 22:51:46.260 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_START_YEAR, PARTY_START_YEAR 2016-10-15 22:51:46.260 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_STOP_YEAR, PARTY_STOP_YEAR 2016-10-15 22:51:46.261 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|COMMUNICATION_REPORTING, COMMUNICATION_REPORTING 2016-10-15 22:51:46.261 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_TEMPERATURE, PARTY_TEMPERATURE 2016-10-15 22:51:46.261 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_STOP_DAY, PARTY_STOP_DAY 2016-10-15 22:51:46.261 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|LOWBAT_REPORTING, LOWBAT_REPORTING 2016-10-15 22:51:46.262 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|WINDOW_OPEN_REPORTING, WINDOW_OPEN_REPORTING 2016-10-15 22:51:46.262 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_START_MONTH, PARTY_START_MONTH 2016-10-15 22:51:46.263 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|CONTROL_MODE, CONTROL_MODE 2016-10-15 22:51:46.263 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_MODE_SUBMIT, PARTY_MODE_SUBMIT 2016-10-15 22:51:46.263 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_START_TIME, PARTY_START_TIME 2016-10-15 22:51:46.263 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_START_DAY, PARTY_START_DAY 2016-10-15 22:51:46.264 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_STOP_TIME, PARTY_STOP_TIME 2016-10-15 22:51:46.264 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: THERMALCONTROL_TRANSMIT|PARTY_STOP_MONTH, PARTY_STOP_MONTH 2016-10-15 22:51:47.027 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_STOP_YEAR, PARTY_STOP_YEAR 2016-10-15 22:51:47.028 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_TEMPERATURE, PARTY_TEMPERATURE 2016-10-15 22:51:47.028 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_START_YEAR, PARTY_START_YEAR 2016-10-15 22:51:47.028 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|FAULT_REPORTING, FAULT_REPORTING 2016-10-15 22:51:47.029 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|FAULT_REPORTING|, FAULT_REPORTING|, 2016-10-15 22:51:47.029 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_STOP_MONTH, PARTY_STOP_MONTH 2016-10-15 22:51:47.029 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_START_MONTH, PARTY_START_MONTH 2016-10-15 22:51:47.030 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_STOP_TIME, PARTY_STOP_TIME 2016-10-15 22:51:47.030 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_STOP_DAY, PARTY_STOP_DAY 2016-10-15 22:51:47.030 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|CONTROL_MODE, CONTROL_MODE 2016-10-15 22:51:47.030 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_START_TIME, PARTY_START_TIME 2016-10-15 22:51:47.031 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_MODE_SUBMIT, PARTY_MODE_SUBMIT 2016-10-15 22:51:47.031 [INFO ] [binding.homematic.type.MetadataUtils] - Description not found for: CLIMATECONTROL_RT_TRANSCEIVER|PARTY_START_DAY, PARTY_START_DAY

Arsur commented 7 years ago

i have the same problem. Iam using homegear as "bridge"

joek commented 7 years ago

Same problem here

kaikreuzer commented 7 years ago

@gerrieg Any idea?

gerrieg commented 7 years ago

At startup, the binding fetches all possible metadata from the gateway. But not all descriptions for the datapoints (eg. for PaperUI) are available. Some can be extracted, but many are missing.

There are two files in the src/main/resources/homematic directory: extra-descriptions.properties extra-descriptions_de.properties

Missing descriptions can be added here.

The log message is only a info, that no description can be generated for UI's, it has no effect on the functionality. In my next PR, i'll reduce the log message from info to debug.

MHerbst commented 7 years ago

I think reducing the log message the debug is a good idea. I will try to add the missing descriptions for my Homematic components to the extra-descriptions file.

MHerbst commented 7 years ago

@gerrieg I did some tests in Method MetadataUtils#getDescription and found a small problem: sometimes the the array passed to getDescription contains empty entries and these entries will then cause problems. Here is an example:

keys[0] = SHUTTER
keys[1] = ERROR
keys[2] = <empty string>

Now the following values of key are tried to retrieve from the properties file

SHUTTER_CONTACT|ERROR|
ERROR|
<empty string>

Because of the trailing | no description can be found.

gerrieg commented 7 years ago

thank you @MHerbst , fixed with https://github.com/openhab/openhab2-addons/pull/1348

MHerbst commented 7 years ago

Solution verified