openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.87k stars 3.58k forks source link

[velux] Broken links in documentation #14157

Closed jlaur closed 1 year ago

jlaur commented 1 year ago

In the Full Example there are links to these files:

However, these links are broken: https://next.openhab.org/addons/bindings/velux/doc/conf/things/velux.things

Furthermore, these four files contain license header information which is not automatically updated by the command mvn license:format - see #14154.

Could these example be embedded directly into the documentation like for all other bindings? This would also allow for syntax highlighting.

jlaur commented 1 year ago

@gs4711, @andrewfg - FYI.

And also @Confectrician in case you would have any comments. 🙂

andrewfg commented 1 year ago

@jlaur /@Confectrician -- this is the same issue as was fixed in the recent "markdown improvements" PRs for other bindings done by @Confectrician in the last months. However I think you did not yet get as far as letter "v" in the list of bindings. ??

andrewfg commented 1 year ago

@Confectrician are you working on these last bindings? If so, I don't want to overlap with you. But if not, then I am happy to make a PR to resolve this Velux binding. => Please advise.

Confectrician commented 1 year ago

Sorry for being late to the party here. I am pretty busy currently. I think i have branch open for the next edits, but i can rebase/merge when i go on with markdown improvements.

I would do it anyway when starting work after this long pause.