OAuth2 client : missing calls to ungetOAuthService and deleteServiceAndAccessToken

[lolodomo]

18 bindings use the OAuth2 client provided by the OH core framework.

Only 10 bindings are calling ungetOAuthService. It could be missing for the following bindings:

• [x] hydrawise => PR #14945
• [x] livisismarthome => PR #14946
• [x] mercedesme => PR #14942
• [ ] mielecloud
• [x] myq => PR #14938
• [x] nest => PR #14940
• [x] googlestt => PR #14936
• [x] googletts => PR #14937

Only ecobee, mielecloud and netatmo bindings are calling deleteServiceAndAccessToken. It could be missing for the following bindings:

• [x] automower => PR #14971
• [x] boschindego => PR #14950
• [ ] bticinosmarther
• [x] ecobee => PR #14980
• [x] ecowatt => PR #14934 and #14978
• [x] groupepsa => PR #14943 and #14977
• [x] homeconnect => PR #14935
• [x] hydrawise => PR #14945 and #14976
• [x] livisismarthome => PR #14946 and #14975
• [x] mercedesme => PR #14942
• [x] myq => PR #14938 and #14974
• [x] nest => PR #14940
• [x] spotify => PR #14947
• [x] webexteams => PR #14979
• [ ] googlestt : it is a service not attached to a thing, not obvious to determine when removing the access token
• [ ] googletts : it is a service not attached to a thing, not obvious to determine when removing the access token

3 bindings are calling addAccessTokenRefreshListener but not removeAccessTokenRefreshListener:

• [x] hydrawise => PR #14945
• [x] livisismarthome => PR #14946
• [x] myq => PR #14938

[lolodomo]

@jlaur : I should update again all bindings (when necessary) because deleteServiceAndAccessToken has to be called in handleRemoval even if no OAuth service was initialized. It is necessary to remove the entries from the storage.

[mhilbush]

@lolodomo The ecobee binding calls deleteServiceAndAccessToken when the Ecobee cloud forces a reauthorization, but not when the thing is removed. I'll submit a PR that calls deleteServiceAndAccessToken when the thing is removed.

[lolodomo]

@jlaur : it is a pity, we did not update the two last ones: bticinosmarther and mielecloud.

[jlaur]

@jlaur : it is a pity, we did not update the two last ones: bticinosmarther and mielecloud.

Yes. For mielecloud I created #14783, but this could be done separately.

[lsiepel]

@lolodomo only a few bindings are left, besides time, any specific reason they are not checked/fixed yet?

[lolodomo]

@lolodomo only a few bindings are left, besides time, any specific reason they are not checked/fixed yet?

I suppose @jlaur and me switched to other PRs.