search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.58k forks source link

[boschshc] Upgrade to REST API version 3.2 #15053

Closed david-pace closed 1 year ago

david-pace commented 1 year ago

Today Bosch announced that in July the Smart Home Controllers will receive an update which does not support REST API version 2.x anymore (https://github.com/BoschSmartHome/bosch-shc-api-docs/issues/80).

This means that we have to update the openHAB binding because we currently use API version 2.1.

GerdZanker commented 1 year ago

The REST API will be updated in about one month and could break existing functionality. Is there a way to provide a change for the released openhab v3.4.x bindings to fix things sooner? A usual pull request is merged to main and therefore to 4.0.0-SNAPSHOT as far as I know.

jlaur commented 1 year ago

Is there a way to provide a change for the released openhab v3.4.x bindings to fix things sooner?

We can cherry-pick the commit into the 3.4.x branch after the PR branch is merged into main.

david-pace commented 1 year ago

@jlaur can you please point me into the right direction about how to cherry-pick this commit onto the 3.4.x branch? I can currently only see branches for 3.0.x, 3.1.x and 3.2.x on the origin side.

jlaur commented 1 year ago

@jlaur can you please point me into the right direction about how to cherry-pick this commit onto the 3.4.x branch? I can currently only see branches for 3.0.x, 3.1.x and 3.2.x on the origin side.

Only maintainers can do this. I'll try to remember to do this when I'm home from work today. Feel free to ping me if I fail. 🙂

openhab-bot commented 1 year ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/will-there-be-a-bosch-smart-home-binding/8910/141

jlaur commented 1 year ago

@kaikreuzer - we have another broken binding, this time not caused by cloud services, but a firmware upgrade. There is a fix cherry-picked into 3.4.x. I'm not sure how much is needed to trigger a hotfix?

kaikreuzer commented 1 year ago

Let's say we definitely do a 3.4 patch release still in July and check what other issues we might want to backport as well, so that it becomes valuable for more people than boschshc users.

jlaur commented 1 year ago

Let's say we definitely do a 3.4 patch release still in July and check what other issues we might want to backport as well, so that it becomes valuable for more people than boschshc users.

Agreed. There will also be a backport of #15187.