[goecharger] Go-E Gemini requires Openhab Addon to be addapted for decimal places

openhab / openhab-addons

Add-ons for openHAB

https://www.openhab.org/

Eclipse Public License 2.0

1.86k stars 3.56k forks source link

[goecharger] Go-E Gemini requires Openhab Addon to be addapted for decimal places #15075

Open ulrichpa opened 1 year ago

ulrichpa commented 1 year ago

As described here, the Openhab Binding for Go-E Chargers needs to be adapted to be able to handle the decimal places in the numbers coming from the newer Go-E Gemini Charger.

Would be great if the binding could be adapted.

lsiepel commented 11 months ago

I'm also working on a different goecharger fix, so i could try to add this too. The mentioned site is in german, could you post the relevant bits in English here? Log file, channels, api model/field or anything relevant to what you actually expect to change.

lsiepel commented 11 months ago

FTR, the V2 handler allready uses double for the nrg data: https://github.com/openhab/openhab-addons/blob/98406476f83d2ee490dee21573e6dc3a0c4089cc/bundles/org.openhab.binding.goecharger/src/main/java/org/openhab/binding/goecharger/internal/api/GoEStatusResponseV2DTO.java#L49

The other class does not: https://github.com/openhab/openhab-addons/blob/98406476f83d2ee490dee21573e6dc3a0c4089cc/bundles/org.openhab.binding.goecharger/src/main/java/org/openhab/binding/goecharger/internal/api/GoEStatusResponseDTO.java#L50

As the Go-E Gemini Charger is newer, i would assume it to use the V2, but did not look at any documentation.

So i would really like to see some debug logs to show the issue in the openHAB binding.

pjgregory commented 9 months ago

I have just installed a Go-E Gemini Charger (3-phase 22KW). I have installed this binding, and created a GO-E thing, but get a communication error when I try to access it.

"COMMUNICATION_ERROR java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $".

I now realise that this binding only officially supports the older HOME+ and Fix models. I am running OH 3.3.0 and have just updated the Go-E to the latest 055.7 firmware. Trying both the V1 and V2 API's give the same error message.

I can try to post logs if you can tell me what would help.

PJG

lsiepel commented 9 months ago

Maybe better to upgrade to 4.0 first as many changes have been merged.

pjgregory commented 9 months ago

I have just upgraded to 4.0.3 with JAVA17 installed automatically as part of the setup on my raspberry pie. The problem remains the same. I have looked a the log with "openhab-cli showlogs and just get the same message

"COMMUNICATION_ERROR java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $".

Any other things I can try? PJG

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

HobMit commented 7 months ago

Has anything been updated here?

lsiepel commented 6 months ago

I have just upgraded to 4.0.3 with JAVA17 installed automatically as part of the setup on my raspberry pie. The problem remains the same. I have looked a the log with "openhab-cli showlogs and just get the same message

"COMMUNICATION_ERROR java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $".

Any other things I can try? PJG

Please create a new issue as that error does not seem to relate to this issue about decimal places.

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

HobMit commented 4 months ago

No changes yet, would be great if someone could fix this...

openhab-bot commented 2 months ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/go-e-charger-wallbox-binding/93338/124

stale[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.