search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.58k forks source link

[boschshc] Binding title mistyped prevents finding it easily #15607

Closed mickymix closed 11 months ago

mickymix commented 12 months ago

I searched for any binding of my latest toy, a Bosch Smart Home 360 camera and...

Current Behavior

I was able to find the documentation on OpenHab resources but wasn't able to find the binding itself... Well, the binding is present in the repository, but searching with the brand name "Bosch" did not go through...

So I started worrying not being available for my build... (v4.0.3)

I noticed that the name of the binding is mistyped as "Bosh", instead of "Bosch".

Possible Solution

If there is no special reason for it (and I did not found any, even after searching for it), I would suggest to fix it. ;-)

Steps to Reproduce (for Bugs)

  1. Open Binding Search Page and type "Bosch"...
  2. No "Bosch Smart Home" binding is found.
  3. Now retype "Bosh" and the binding is there.

My Environment

lsiepel commented 12 months ago

Äs it is not fully clear (to me) what search box you are talking about:

For openHAB.org @ https://www.openhab.org/addons/ : image

For openHAB 4.0.3 @ http://openhabhost:8080/settings/addons : image

Maybe you mean some other place, but to me both look fine.

mickymix commented 11 months ago

I was talking of the second image: the search which is available within OpenHab itself (and I was referring to the v4.0.3 too).

And you are right: now I searched it once again and I was able to find it.

Screenshot 2023-09-18 07 35 08

But since I'm sure of what I saw, I remember having applied one modification only: I have removed the binding, which was already installed (my Bosch Smart Camera 360 does not work with a Bosch Controller, but with its app only, so the binding is not useful for me).

To be able to reproduce the bug, I installed the binding once again and the "search unavailability" only happens when the binding is already installed (as it is mystyped).

The problem (the bug) is that the binding needs to be installed, to be "unsearchable".

Screenshot 2023-09-18 07 34 48

I hope having explained myself a little bit more.

I don't know if I need to edit the main message to report this further discovery or what... I'm not so used to use github... :-)

lsiepel commented 11 months ago

I searcehd the full repo, the only occurence i could find of "bosh" was in the italian translation. I tried to update that from crowdin, but never done that before, so not sure if it was right.

I still wonder why it is different between searched and installed. Maybe @florian-h05 knows where this string comes from?

mickymix commented 11 months ago

Thank you for your kind and helpful investigation.

I probably forgot to mention I'm Italian and I use OpenHab in italian too... (for the reasons explained below...)

I did not consider this could be a problem of translation (and effectively, what you found makes sense too).

Being a problem of the Italian translation only, at this point, I'm happy this did not involved many other users and I regret having opened a request for this small glitch only.

I'll have a look at crowdin myself too and validate your fix, if it might help.

Since I always try to avoid translation problems, I try to keep cores in english, but this installation is for "family use" and they strongly prefer local language. :-P

Thank you !

lsiepel commented 11 months ago

Hopefully you can fix it in crowdin if i didn't succeed. Atleast we know where the issue is.

florian-h05 commented 11 months ago

I still wonder why it is different between searched and installed. Maybe @florian-h05 knows where this string comes from?

This is just guessing, I don’t know it for sure: I guess when the binding is not installed, the name is taken from feature.xml (which is an OSGi/Apache Karaf file). As soon at is gets installed, addon.xml and the translations become available and will be used. Also see https://github.com/openhab/openhab-core/issues/1701#issuecomment-704881334, which I just found - I was looking for another comment, but this one is even better.

I searcehd the full repo, the only occurence i could find of "bosh" was in the italian translation. I tried to update that from crowdin, but never done that before, so not sure if it was right.

I have just checked CrowdIn, a proof reader approved your translation, so it should get synced to the repo soon.

FYI for German translations, I have the right to proof read, but only for German.