openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.56k forks source link

[pentair] Pool/Spa temperature are not updating #16302

Open markus7017 opened 6 months ago

markus7017 commented 6 months ago

Even the controller is initialized and communication is shown in the log the current pool and spa temp only get rarely updated. It turned out that the temps are updated when receiving the heat status message from the controller. This contains the heat status, but not the current water temperature. This comes with the controller status, so updates to the poolheat and spaheat channel groups were added there.

@jsjames This Issues should be linked to the pending PR https://github.com/openhab/openhab-addons/pull/13485

jsjames commented 6 months ago

Yes, the actual water temp is only a part of the Status packet and not the HeatStatus packet. I grouped them together logically in openhab in the Pool and Spa groups since that made more sense. I think my controller sends the HeatStatus message more frequently so I never noticed the temp never getting updated.

I found your initial edits here in a commit to the main GitHub. I don’t see any additional edits at this point though. 1d96eb9 https://github.com/openhab/openhab-addons/commit/1d96eb9652c7a4327f036c7365eb423557099a4a Debbuging optimized: Display device id for each message, show functional/status messages on DEBUG and hex dump with TRACE; Even though I didn’t see your edits, I did add a change to update the temperature whenever the Status packet is received. I presume this is similar to the change you had made, but you might want to confirm. I checked it into the repository.

Thanks, Jeff

On Jan 18, 2024, at 6:27 PM, Markus Michels @.***> wrote:

Even the controller is initialized and communication is shown in the log the current pool and spa temp only get rarely updated. It turned out that the temps are updated when receiving the heat status message from the controller. This contains the heat status, but not the current water temperature. This comes with the controller status, so updates to the poolheat and spaheat channel groups were added there.

@jsjames https://github.com/jsjames This Issues should be linked to the pending PR #13485 https://github.com/openhab/openhab-addons/pull/13485 — Reply to this email directly, view it on GitHub https://github.com/openhab/openhab-addons/issues/16302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHUUTJPRYCPMMRD2LBQBHDYPHKYBAVCNFSM6AAAAABCBH3WJOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DSNBSGY4DCNA. You are receiving this because you were mentioned.