search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.88k stars 3.59k forks source link

[boschshc] Location properties are not updated #16599

Open david-pace opened 7 months ago

david-pace commented 7 months ago

If devices are moved to a different room in the Bosch Smart Home app, the location change is not reflected in the corresponding thing properties. This was originally reported here by @mike-bike:

Minor observation: Dimmer Device shows the Bosch Room as Location property in the thing. Seems to be a new feature. However, it does not get any updates. In the Bosch app I have moved the device into a new room, but the change is not reflected in the Thing - even a OpenHAB restart does not force an update... I'd suggest removing that property if updates are not coming through.

Expected Behavior

Whenever a device location is changed in the Bosch Smart Home app, the corresponding thing property should be changed as well.

Current Behavior

Once a thing is added, the location property does not change anymore.

Steps to Reproduce (for Bugs)

  1. Create a thing (bug was reported for a dimmer device)
  2. Inspect the location property of the thing
  3. Move the device to a different room using the Bosch Smart Home app
  4. Inspect the location property again. It did not change accordingly.

Context

Minor issue, does not affect the actual thing / channel logics.

david-pace commented 3 months ago

Additional requirement found in https://github.com/openhab/openhab-addons/issues/16590#issuecomment-2254345570: the property name spelling does not adhere to the coding guidelines. We should change it from Location to location when implementing the fix.