openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.9k stars 3.59k forks source link

[siemensrds] Fix setting of target temperature #17697

Closed andrewfg closed 3 weeks ago

andrewfg commented 3 weeks ago

Resolves #17695

Signed-off-by: AndrewFG software@whitebear.ch

andrewfg commented 3 weeks ago

Can I support you somehow fixing this issue?

@oxigen-dev I fixed your issue; you can download the Jar for testing org.openhab.binding.siemensrds-4.3.0-SNAPSHOT.jar.zip

andrewfg commented 3 weeks ago

Should we await user tests before merging?

@jlaur not really necessary as I have tested on my own system. I posted the Jar for the OP to use if he doesn't want to wait for the new release or milestone.

jlaur commented 3 weeks ago

I posted the Jar for the OP to use if he doesn't want to wait for the new release or milestone.

The fix seems quite safe, so we can also backport to 4.2.x?

andrewfg commented 3 weeks ago

we can also backport to 4.2.x?

Sure.

oxigen-dev commented 3 weeks ago

Can I support you somehow fixing this issue?

@oxigen-dev I fixed your issue; you can download the Jar for testing org.openhab.binding.siemensrds-4.3.0-SNAPSHOT.jar.zip

Thanks for the very quick support, I can confirm it is working again!