search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.9k stars 3.59k forks source link

[ipcamera] ONVIF events are processed faster, and adds a choice of what event method will be used. #17732

Closed TheNetStriker closed 2 weeks ago

TheNetStriker commented 2 weeks ago

I made various changes and fixes to the ONVIF connection in the IpCamera binding. I already discussed those changes in this community thread.

The addon now checks if there is support for PullPoint and WSBaseNotification subscriptions. PullPoint subscriptions are prefered because we have more control over it. I also added an Thing option to force a specific ONVIF event service type.

This also fixes an error with older Reolink cameras where the scheduleVersion is null in the Reolink API.

openhab-bot commented 2 weeks ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ipcamera-fixes-and-optimizations-to-onvif-connection/160097/12

Skinah commented 2 weeks ago

Thank you for the changes. Just need to get the DCO happy when you have time. LGTM.

TheNetStriker commented 2 weeks ago

Thank you for the changes. Just need to get the DCO happy when you have time. LGTM.

I already signed off the commit, but I guess the problem is that I had not set my real name in my GitHub profile. (Regarding the contribution guidelines I have to sing off with my real name)

I just added my real name to my GitHub profile. Can you manually trigger the DCO to run again? I hope it works after that.

lsiepel commented 2 weeks ago

Thank you for the changes. Just need to get the DCO happy when you have time. LGTM.

I already signed off the commit, but I guess the problem is that I had not set my real name in my GitHub profile. (Regarding the contribution guidelines I have to sing off with my real name)

I just added my real name to my GitHub profile. Can you manually trigger the DCO to run again? I hope it works after that.

Next to the DCO check is a 'details' link that shows a page on how to rewrite the signoff message. You could also create an arbitrary commit with the right signoff (like merge master into your feature branch)

TheNetStriker commented 2 weeks ago

Thank you for the changes. Just need to get the DCO happy when you have time. LGTM.

I already signed off the commit, but I guess the problem is that I had not set my real name in my GitHub profile. (Regarding the contribution guidelines I have to sing off with my real name) I just added my real name to my GitHub profile. Can you manually trigger the DCO to run again? I hope it works after that.

Next to the DCO check is a 'details' link that shows a page on how to rewrite the signoff message. You could also create an arbitrary commit with the right signoff (like merge master into your feature branch)

Thanks, I was able to trigger the DCO again.