openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.9k stars 3.59k forks source link

[ism8] Add manufacturer Wolf to add-on name field #17747

Closed holgerfriedrich closed 6 days ago

holgerfriedrich commented 1 week ago

This will show ism8 binding when users search for "wolf".

https://github.com/openhab/openhab-addons/issues/17682#issuecomment-2469187287

We have two add-ons, ism8 and wolfsmartset (you will need one or the other depending on the smart home interface installed in the heating system). When a user types "wolf" into the search field of the add-on store, I would like to see both add-ons shown.

Current behaviour is as follows: Whey I search for "wolf", I get only the latter. The search mechanism seems to look at the name of the binding, but not at the description (which contains Wolf for both add-ons). Should I change the field name to "Wolf ISM8" in addon.xml or do you know a better way?

I am not sure if this should be done this way, as it feels somehow inconsistent with the actual name of the binding.

lsiepel commented 1 week ago

Support for the suggestion finder could also eliminate the need to search for this binding?

holgerfriedrich commented 1 week ago

Support for the suggestion finder could also eliminate the need to search for this binding?

I took a Wireshark dump for about 15 mins on an ISM8 with (older) firmware 1.60: On startup of the heating system, it shows MDNS traffic like this; image We have an entry in addons.xml,

<name>mdnsServiceType</name>
<value>_ism7._tcp.local.</value>

(I did not try out if this actually works).

The problem is, that I did not see any further activity on MDNS after startup of the heating system - and you typically do not power it down very often. So from my perspective, auto-detection is possible, but quite limited.

holgerfriedrich commented 6 days ago

Thanks, @jlaur, for the feedback.

I have opened openhab/openhab-webui#2870 and will close this one.

openhab-bot commented 2 days ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/entsoe-binding-4-0-0-5-0-0/149699/123