search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.58k forks source link

New binding: innogy SmartHome Binding #2263

Closed ollie-dev closed 6 years ago

ollie-dev commented 7 years ago

I am preparing the pull request for the innogy SmartHome Binding. Please tag this as "enhancement".

kaikreuzer commented 7 years ago

Sounds wonderful :-)

stritti commented 7 years ago

just for reference: the pull request: https://github.com/openhab/openhab2-addons/pull/2407

Looking forward the merge :))

LMS0815 commented 6 years ago

any merge yet?

kaikreuzer commented 6 years ago

Github isn't able to render https://github.com/openhab/openhab2-addons/pull/2407 anymore, so there wasn't any progress :-(

@ollie-dev I just talked to @htreu and we wondered whether it makes sense if you'd create a new PR with the current state of your code, so that review can continue? You would have to point us to the open discussions that we might miss, though...

ollie-dev commented 6 years ago

Yes, it takes me half an hour to get the pr rendered. And additionally, I currently have issues with my development setup. Even a completely fresh Eclipse install (.p2 an .m2 deleted before), OH2 seems to start, but the service is not available at localhost:8080 (or the current IP) and times out. I even tried a different and new account on my Mac. So this is what I have to fix first.

I really hope to get this finished soon....

On Tue, Jan 16, 2018 at 12:14 PM, Kai Kreuzer notifications@github.com wrote:

Github isn't able to render #2407 https://github.com/openhab/openhab2-addons/pull/2407 anymore, so there wasn't any progress :-(

@ollie-dev https://github.com/ollie-dev I just talked to @htreu https://github.com/htreu and we wondered whether it makes sense if you'd create a new PR with the current state of your code, so that review can continue? You would have to point us to the open discussions that we might miss, though...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/openhab2-addons/issues/2263#issuecomment-357929149, or mute the thread https://github.com/notifications/unsubscribe-auth/AG2s2zWycEobijnGvEMlu7vujGWnNvIBks5tLISTgaJpZM4NaXT_ .

htreu commented 6 years ago

regarding start issues: did you reboot your machine? I had this issue recently that openHAB/ESH wouldn't stop properly and block port 8080. All there was left was a zombie process which you can not get rid off. only reboot helps. You can find the process by netstat -anv | grep 8080 (not by lsof unfortunately).

ollie-dev commented 6 years ago

Yes, but even after a fresh reboot (which I did again a couple of minutes ago), it doesn't work and I get the following exception, which seems to point to a problem with audio ("!MESSAGE Circular reference detected trying to get service {org.eclipse.smarthome.core.audio.AudioSink}={service.id=78, service.bundleid=15, service.scope=bundle, component.name=org.eclipse.smarthome.io.javasoundsink, component.id=64}"):

...

kaikreuzer commented 6 years ago

Sounds like https://github.com/eclipse/smarthome/issues/4955.

ollie-dev commented 6 years ago

I added a new PR. Seems like it ended in the old PR (I used the same branch name)? Most things from recent reviews are addressed. The main thing lacking here is the oauth website, which I have to implement later. In the meanwhile, feel free to check the code again. ;)

htreu commented 6 years ago

@ollie-dev, thanks for the update. Could you please rename your branch and create a fresh PR against this repo? Otherwise we are not able to comment and review the code again. The same branch name will always update an existing PR. Thanks. Cheers, Henning.

ollie-dev commented 6 years ago

See https://github.com/openhab/openhab2-addons/pull/3227

htreu commented 6 years ago

@ollie-dev since innogy has landed, can we close here? Thanks.