search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.58k forks source link

[onewire] Missing source code for OneWire binding version 2 #3943

Closed mgwoj closed 5 years ago

mgwoj commented 5 years ago

Documentation at page https://www.openhab.org/addons/bindings/onewire1/ mention that version 1 of OneWire binding is obsolete and suggests to use version 2.

OBSOLETE BINDING

This 1.x binding is obsolete; it has been replaced by the 2.x onewire binding which you should use instead.

There is nice documentation at page https://www.openhab.org/addons/bindings/onewire/ for version 2, however there is no source code for this binding at the https://github.com/openhab/openhab2-addons/tree/master/addons/binding.onewire

Expected Behavior

Please provide missing source code and make this binding available for installation.

martinvw commented 5 years ago

That seems to be a bug in the documentation, it would be great if you could open an issue in

https://github.com/openhab/openhab-docs

There seem to be two problems the openHAB 2 binding is called onewiregpio and the link misses the org.openhab part

https://github.com/openhab/openhab2-addons/tree/master/addons/binding/org.openhab.binding.onewiregpio

mgwoj commented 5 years ago

I think you are not right - based on the documentation - OneWire and OneWireGPIO seems to be different bindings. First on is using One Wire Server, second is using only local IO ports.

martinvw commented 5 years ago

I asked some clarification to @kaikreuzer who moved it to the legacy bindings 18 days ago.

wborn commented 5 years ago

This OneWire binding is part of Eclipse SmartHome repository now so that's why you can't find it in this repository.

Follow me to find the source code. :smile:

J-N-K commented 5 years ago

The OneWire v2 binding is part of ESH, therefore it is in eclipse/smarthome, not in openhab2-addons. It obsoletes the OneWire v1 binding, but not the OneWire GPIO binding.

martinvw commented 5 years ago

Great, so the problem might be:

wborn commented 5 years ago

that docs does not render links to ESH correctly

The link in the footer is wrong for sure:

Caught a mistake or want to contribute to the documentation? Edit this page on GitHub

It points to: https://github.com/openhab/openhab2-addons/edit/master/addons/binding/org.openhab.binding.onewire/README.md

wborn commented 5 years ago

Looks like we are missing a feature for the ESH OneWire binding so it will not show up in the openHAB addons. The website also uses the feature definitions to determine if it is an ESH project and adds a proper footer accordingly. E.g. Astro Binding has an ESH footer.

I'll create an openhab-distro PR to add the OneWire binding.

wborn commented 5 years ago

Please provide missing source code and make this binding available for installation.

Thanks for creating the issue. It should be possible to install the binding in the next 2.4.0-SNAPSHOT build (1364 or newer) since it will contain https://github.com/openhab/openhab-distro/pull/765 .

mgwoj commented 5 years ago

After updating OpenHab instance to the latest version the binding is available for the installation. Thank you for the prompt response.

However link on the page https://www.openhab.org/addons/bindings/onewire/ to edit the document is still pointing to the non-existent location https://github.com/openhab/openhab2-addons/edit/master/addons/binding/org.openhab.binding.onewire/README.md

kaikreuzer commented 5 years ago

I've just triggered https://openhab.ci.cloudbees.com/view/Documentation/job/gather-external-docs/, which should update the docs within the next hour.