search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.88k stars 3.59k forks source link

[neato] Clean command don't work anymore #4430

Closed Alessandro65 closed 5 years ago

Alessandro65 commented 5 years ago

Expected Behavior

Sending "clean" command the robot should start.

Current Behavior

Sending "clean" command nothing happens. The log traces the error "Unknown service for houseCleaning: basic-4. Will not start house cleaning!"

Detailed log: Neato_log_20181223.txt

Possible Solution

It looks like Neato updated the API services as “basic-4” is not handled in the binding. Likely this is related to the new zone functionality. Change the binding to handle basic-4

Your Environment

OpenHab 2.4 stable release Neato binding 2.4.0 Neato BotVac D7 Connected

jjlauterbach commented 5 years ago

So I looked into this issue a bit yesterday and attempted to put in a simple fix to send the "basic-3" messages. Unfortunately, that resulted in an error response "invalid_entry" from the Neato API. So far I haven't been able to find any documentation for the "basic-4" houseCleaning service. I did email Neato's development support and ask them for some guidance.

So at this point, I don't see a quick fix until we can get the message spec for the basic-4 service.

Alessandro65 commented 5 years ago

Maybe you can look at the new version of pybotvac Python library, where the problem has been solved yet. https://github.com/stianaske/pybotvac

In particular: https://github.com/stianaske/pybotvac/blob/master/pybotvac/robot.py

Alessandro65 commented 5 years ago

No news on this?

jjlauterbach commented 5 years ago

This issue should be closed. The fix was merged in under https://github.com/openhab/openhab2-addons/pull/4587.

Looks like there was a typo in the commit message in linking it to this issue.

cweitkamp commented 5 years ago

@Alessandro65 @jjlauterbach Do you consider this issue as solved?

Alessandro65 commented 5 years ago

The issue has been solved in binding 2.5.0-SNAPSHOT As I'm on OH 2.4.0 stable I had to manually place the above binding in my openhab2-addons folder. No way to update the binding 2.4.0 stable for this issue?

cweitkamp commented 5 years ago

Nope, no way to include the fix in OH 2.4 stable. You either have to install the binding manually or upgrade your version to snapshot or milestone build.