Closed wborn closed 4 years ago
Ok, where/how can I execute the build? Is there a separated Git project?
You can port the add-ons using this script. But I don't think there's any need. Just remove the I18nProviderImpl
from the imports and use something that implements the TimeZoneProvider
instead. If that builds with OH2 it should also work with OH3. :-)
Ok, thank you for the fast feedback.
The pull-request is now created, see https://github.com/openhab/openhab-addons/pull/7954
Thanks it works!
When you build the ported OH3 add-ons, the build fails to compile the
NAPresenceCameraHandlerTest
class because theI18nProviderImpl
constructor changed with https://github.com/openhab/openhab-core/pull/1487.There should not be any usages of internal OHC/ESH classes in tests at all and it would be better if the build failed whenever they are used in imports.
Instead the
NAPresenceCameraHandlerTest
should use theTimeZoneProvider
interface and use it with a mock for instance.Can you have a look at this @Novanic? This import was added in https://github.com/openhab/openhab-addons/pull/7927.