lolodomo
commented
3 years ago Do you encounter this problem only for items managed by the unofficial Isy binding ? What other bindings ?
Can you tell me what Isy thing type and what channel your item is linked to ?
The strange thing in your logs is that you received an ItemStateEvent event with OFF rather than 0. I think it could be due the way the binding is implemented. It updates the channel state with an OnOffType state even when the channel is not a Switch. https://github.com/HentschelT/openhab2-addons/blob/master/addons/binding/org.openhab.binding.isy/src/main/java/org/openhab/binding/isy/handler/IsyDeviceHandler.java#L76
The problem could be due to this unusual way to update the channel state and could explain why I never encountered it and can't reproduce it in practice.
My idea is to consider ItemStateChangedEvent in addition to ItemStateEvent to cover these cases. I just have to be sure that it will not produce regression.
jsiemon
Binding Name
OpenHAB Remote Binding
Expected Behavior
Bi-directional link between OH2 and OH3 Items.
Current Behavior
I have noticed an issue that continues to plague its use in my setup. I am trying to link my OH2 2.5.9 setup with OH3 M3. Both are running in Dockers on the same UnRaid server on the same subnet (br0) with unique IPs and ports set to 8080. OH2 has been working flawlessly for almost 2 yrs now. I have an extensive ISY/Insteon installation that OH2 automates and for which there is no OH3 binding as of today. I am able to link OH3 to OH2 and control OH2 Things/Items from OH3. However any changes made to Items using OH2 are not reflected in my linked Items in OH3. Going the other direction OH3 to OH2 works fine and changes are properly reflected in both OH2 and OH3. My understanding is that the binding is bi-directional, but in my setup it appears to only be OH3 -> OH2, not OH2-> OH3. If I restart OH3 then changes made in OH2 prior to the restart seem to be reflected, but no real time updates seem to happen. This issue seems to affect dimmer type switches mostly. Simple ON/Off switches seem to get updated correctly most of the time.
My Items are created using text based files. For this exercise/example to demonstrate the issue I am using a dimmer for fireplace lighting. The Item declaration is the same for both OH2 and OH3.
Item Definitions and Logs
OH 2 Item:
Dimmer v2A35C71FireplaceLoadLevel "Fireplace Lighting" (Group_HabPanel_Dashboard, PubItems_CMD, gLighting, gFamilyRoom) ["WallSwitch"]
OH3 Item:
Dimmer v2A35C71FireplaceLoadLevel "Fireplace Lighting" (Group_HabPanel_Dashboard, PubItems_CMD, gLighting, gFamilyRoom) ["WallSwitch"]
When Issuing a command from OH2 to adjust the Fireplace Light I see these events in the OH2.events log Turning it OFF from 73% state then turning on to 73% state.
2020-11-29 12:33:10.909 [vent.ItemStateChangedEvent] - v2A35C71FireplaceLoadLevel changed from 73 to 0 2020-11-29 12:33:20.923 [vent.ItemStateChangedEvent] - v2A35C71FireplaceLoadLevel changed from 0 to 73 The corresponding OH2.log entry is
2020-11-29 12:33:10.901 [TRACE] [sy.internal.IsyWebSocketSubscription] - Parsing message: [<?xml version="1.0"?>DOF 0 2A 35 C7 1 ST 0 2A 35 C7 1 _1 3 [ 2A 35 C7 1] DOF 0 _1 3 [ 2A 35 C7 1] ST 0
2020-11-29 12:33:20.915 [TRACE] [sy.internal.IsyWebSocketSubscription] - Parsing message: [<?xml version="1.0"?>DON 0 2A 35 C7 1 ST 188 2A 35 C7 1 _1 3 [ 2A 35 C7 1] DON 0 _1 3 [ 2A 35 C7 1] ST 188
020-11-29 12:33:10.909 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Received event name message date {"topic":"smarthome/items/v2A35C71FireplaceLoadLevel/state","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\"}","type":"ItemStateEvent"} 2020-11-29 12:33:10.910 [DEBUG] [l.handler.RemoteopenhabBridgeHandler] - Unexpected value type OnOff for item v2A35C71FireplaceLoadLevel 2020-11-29 12:33:10.910 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Received event name message date {"topic":"smarthome/items/v2A35C71FireplaceLoadLevel/statechanged","payload":"{\"type\":\"Percent\",\"value\":\"0\",\"oldType\":\"Percent\",\"oldValue\":\"73\"}","type":"ItemStateChangedEvent"} 2020-11-29 12:33:10.910 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Ignored event type ItemStateChangedEvent for topic smarthome/items/v2A35C71FireplaceLoadLevel/statechanged
2020-11-29 12:33:20.923 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Received event name message date {"topic":"smarthome/items/v2A35C71FireplaceLoadLevel/state","payload":"{\"type\":\"Percent\",\"value\":\"73\"}","type":"ItemStateEvent"} 2020-11-29 12:33:20.924 [DEBUG] [l.handler.RemoteopenhabBridgeHandler] - updateState remoteopenhab:server:openhab25x:v2A35C71FireplaceLoadLevel with 73 2020-11-29 12:33:20.924 [TRACE] [internal.events.ThreadedEventHandler] - inspect event: org.osgi.service.event.Event [topic=openhab] {topic=openhab/items/v2A35C71FireplaceLoadLevel/state, source=remoteopenhab:server:openhab25x:v2A35C71FireplaceLoadLevel, type=ItemStateEvent, payload={"type":"Percent","value":"73"}, timestamp=1606671200924} 2020-11-29 12:33:20.924 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Received event name message date {"topic":"smarthome/items/v2A35C71FireplaceLoadLevel/statechanged","payload":"{\"type\":\"Percent\",\"value\":\"73\",\"oldType\":\"Percent\",\"oldValue\":\"0\"}","type":"ItemStateChangedEvent"} 2020-11-29 12:33:20.924 [TRACE] [nternal.rest.RemoteopenhabRestClient] - Ignored event type ItemStateChangedEvent for topic smarthome/items/v2A35C71FireplaceLoadLevel/statechanged 2020-11-29 12:33:20.925 [TRACE] [ab.core.internal.items.ExpireManager] - Received '73' for item v2A35C71FireplaceLoadLevel
Just to put a final point on this, if I change the state of the Fireplace Light from OH3 I do get an event in the OH3events.log as shown below, and the light dims as expected.
2020-11-29 12:58:47.127 [ome.event.ItemCommandEvent] - Item 'v2A35C71FireplaceLoadLevel' received command 20 2020-11-29 12:58:47.156 [vent.ItemStateChangedEvent] - Item 'v2A35C71FireplaceLoadLevel' changed from 73 to 20