search

openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.86k stars 3.57k forks source link

[openweathermap] channel station#location is wrong #9754

Open krocans opened 3 years ago

krocans commented 3 years ago

Coordinates returned by OWM API {"coord":...{"lon":...,"lat":...}} are not location of weather station where measurements are done but coordinates for which weather is requested - the same as entered in thing config [location=...].

So putting this data in channel "station#location" is wrong/misleading an I guess channel should be named differently, moved to "current" group or something like that.

lolodomo commented 3 years ago

This is something that has changed. Before, the API was returning a real station position. Now, apparently, it does not. It should be checked if it is only in particular cases or in all cases. If in all cases, this channel should be simply removed.

lsiepel commented 1 year ago

@krocans The last two years, many PR's to this binding have been merged. Just to verify, is this problem still existing with openHAB 3.4.0?

lolodomo commented 1 year ago

At least nothing was charged regarding this channel.

lsiepel commented 1 year ago

There might be more to it as there does not seem to be any weather station related fields anymore (id, name, location).

See here: https://openweathermap.org/api/one-call-3 So i guess the whole station group can be removed. But because i don't use this binding, and an account is required, it might be better that someone else picks that up with more knowledge to this binding. Maybe @cweitkamp as he is listed as codeowner?

lolodomo commented 1 year ago

One Call API is only an additional API you use but, if I am not wrong, not the main API.

lsiepel commented 1 year ago

I have been using OWM for some time now and i live in Groningen, i would expect OWM to get the data from Eelde a near airport. But instead it shows a location close to our house. I can't find any clear information abou tthe used weather station on the OWM website.