Status bar notification not cleared when visiting notifications page

openhab / openhab-android

openHAB client for Android

https://play.google.com/store/apps/details?id=org.openhab.habdroid

Eclipse Public License 2.0

606 stars 312 forks source link

Status bar notification not cleared when visiting notifications page #1348

Open maniac103 opened 5 years ago

maniac103 commented 5 years ago

Actual behaviour

Status bar notification isn't cleared when visiting the notification page in the app

Expected behaviour

Status bar notification should be cleared

Steps to reproduce

Get a notification from the server
Open app from launcher
Go to notification page via drawer

Can you reproduce the issue in demo mode?

No (no notifications in demo mode)

Client

Android version: 9
Device model: OnePlus 6
Stock or customized ROM: LineageOS 16.0
App version: 2.6.19 beta
Build flavor : full
Device language: DE

Server

Server version: 2.4
Reverse Proxy: no
Authentication method : none

openHAB Cloud

openHAB Cloud version: myopenhab
Self hosted cloud or myopenhab.org: myopenhab
Authentication method : user/pw

Kshitij09 commented 5 years ago

I'd like to work on this issue.

mueller-ma commented 5 years ago

@Kshitij09 You can register here (use dummy values for openHAB UUID and secret. After logging in, hover over your mail address and click on "Devices". You can send a message to your device from there. In the app go to settings, remote connection, enter "https://myopenhab.org" as URL and your address and password as user name and password.

Kshitij09 commented 5 years ago

Okay. Thanks! I'm working on this issue now. Could you assign it to me ? Will make sure it'll be done as soon as possible.

mueller-ma commented 5 years ago

Go for it :)

Kshitij09 commented 5 years ago

I've made changes to clear notification from current as well as other devices logged in by same user. The reason I didn't commit these many days was I thought the FCM should clear notification from same device as well, which it wasn't. After clarification from @maniac103 I got to know how it is supposed to work and hence I've implemented both of them. Let me know if any other changes to be done.