Release 2.0

[digitaldan]

@mueller-ma , @lolodomo , @FlorianSW , @maniac103

Hi all, I would like to cut 2.0 this weekend, I will plan on going through the PR's we have and merging them. If there are PR's you think need more work, or could wait until 2.0.1, please let me know. These are the PR's that seem to be a candidate for release that are not yet merged.

481

482

493

497

498

@FlorianSW is #391 ready or does this need more testing? @mueller-ma is #496 ready to merge or should i help test this?

Let me know if this looks right to you, thanks!

[maniac103]

496 and #497 look like they would need the largest testing. I also have some specific comments about #496 (will add them later), my gut feeling is we shouldn't rush out this one.

[ThomDietrich]

My believe is that @digitaldan wants to release before the openHAB 2.2 release. 👍

[maniac103]

@ThomDietrich Oh, that one is imminent? Please do me a favor and review https://github.com/openhab/openhab2-addons/pull/2932 before that happens so I can finally update to OH2 - thanks ;-)

[mueller-ma]

I preffer that my two PRs about the foss build #482 and #493 will be merged AFTER the 2.0 release. We dont need them for the full version.

481 looked quite good to me, but I didnt review the changes after my initial review there.

391 the last time I tried the migration it didnt work, but @FlorianSW said he fixed it.

[mueller-ma]

I tested #496, but only for local connections.

[mueller-ma]

@karafyllidis @mgarciate @lolodomo @naofum @jvitkauskas @Maurits28 Please update the translations. I'll have a look at the german one.

[lolodomo]

497 is very simple and don't require lots of tests. #481 should require more attention.

I am working on the fix relative to the 30 seconds useless refresh. I would like this fix to be included in the comiong 2.0. I implemented the fix very quickly this morning but unfortunately I did not notice the expected result as it avoided a refresh only every minute rather than every 30 seconds. I have to investiguate if there is something in the demo that could explain this behaviour. I will try to provide the final fix today or tomorrow (Saturday).

[mueller-ma]

I would like to see #476 resolved before a new version is built. I'd suggest to wait until it is resolved or - if we need the version this weekend - release a commit before #442 was merged.

[lolodomo]

Ok, I finally submitted PR #501 for the 30s refresh. Unfortunately, I discovered a stupid bug in my fix for the sitemap REST API. I will fix it in parallel. It would make sense to wait for the fix in server before merging the PR #501.

[FlorianSW]

For #391 I would really like to see it in the next version (2.0) of the app. I already fixed all points and implemented all suggestions (as far as I can see), however, it would be great, if @mueller-ma could take a look to the migration part, which worked in my testing (building apk of older version -> installing -> changing url -> building apk of this version and install -> see if the url was migrated) :) Otherwise the PR should be fine.

Also: It's not a real blocker, however, it would be cool, if we could fix #479 before the next release, too, but I think we can't get it fixed before this weekend anymore :)

[lolodomo]

@digitaldan : I would suggest to publish first a version 1.9 this weekend. I think the version 2.0 should include the suppression of the top right menu. It remains 2 entries in this menu, the RFC tag and the selection of the default sitemap. As already proposed, the selection of the default sitemap should be moved to the settings. Then you could publish a version 2.0 just after the openHAB 2.2 is released in one week. This 2.0 would include the annoying issue causing a refresh of the app every 30 seconds.

[lolodomo]

Please include #503 an update of the French translation.

[mgarciate]

@mueller-ma do you have the German translation updated at master? I'd like to check differences between GE and SP, and fill the resource with the new ones.

[mueller-ma]

@mgarciate In the german translation only the translations for "Bitmap" and "Vector" are missing.

[mgarciate]

Alright, I'll upload the translation this evening.

[mueller-ma]

I'll added a 2.0 milestone to all issues and PRs which would be nice to have in the next version.

[boc-tothefuture]

I am going to try and get to #476 today

[boc-tothefuture]

PR #507 submitted to resolve #476

[digitaldan]

If anyone wants to start the release notes for the play store that would be great. For example:

• Updated Logo
• New Translations
• Bug Fixes
• ....

[mueller-ma]

On it

[digitaldan]

Thanks!

[mueller-ma]

I think we should also add it in this repo #510

[mgarciate]

Spanish translation in #512

[jvitkauskas]

Lithuanian, Russian translations in https://github.com/openhab/openhab.android/pull/513

[lolodomo]

Kai is building a new server version including the REST API fix so please include #501 in version 2.0.

[karafyllidis]

Greek translations in #518

[digitaldan]

FYI I just pushed a change so every merge into master will trigger the build AND push a signed APK file to https://github.com/openhab/openhab.android/releases/tag/latest-master if the build is successful

[digitaldan]

well, it was working! trying to debug why its now not updating, stay tuned.

In the mean time #499 and #510 are the only un-merged PR's. I'll merge #499 here in just a min, @mueller-ma that should complete our final code change for the build, if we are happy we can merge the readme and tag the release.

[lolodomo]

Please include #501.

[digitaldan]

Just merged #501

[lolodomo]

Thank you

[mueller-ma]

516 is the last PR for 2.0

[digitaldan]

Final APK is here https://github.com/openhab/openhab.android/releases/tag/2.0.0-PRE , I start setting up the play store for release, I'll post back here however before I push anything.

[digitaldan]

@mueller-ma #510 looks acceptable for the play store notes, we just need a German translation. The autogenerated one might be a bit long :-)

[digitaldan]

Well, we have a 500 character limit for notes in the play store for each language, so we are going to need a smaller list, this is the format.

<en-US>
<h3>Added</h3>

• Add adaptive app icon
• Add two new themes
• Add app intro
• Add about screen
• Implement support for HSL videos
• Add theme support for charts. Need openHAB server > 2.1
• Added separate user and password settings for local and remote connection

<h3>Changed</h3>

• Update app icon
• Improved selection and setpoint items
• Move settings to the side menu
• Improved error messages
• Improved charts size. Need openHAB server > 2.1
• Better handling of image items
• Right align selection value
• General performance improvements
• Update translations

<h3>Fixed</h3>

• Fixed overlapping label and value
• Fixed a bug where images and charts were not shown
• Fixed a bug where notification were not shown when on WIFI
• Fixed a bug where no charts was shown when icon type set to SVG
• Fixed some bugs where wrong icon was shown
• Removed useless sitemap refreshes

<h3>Removed</h3>

• Remove support for controlling items via volume buttons
• Remove Bindings and Discovery funtionality. Please use PaperUI instead
</en-US>

<de-DE>
Enter or paste your release notes for de-DE here
</de-DE>

I can start working on this in a few hours

[mueller-ma]

<en-US>
<h3>Added</h3>

• Add new themes
• Add app intro
• Added separate user and password settings for local and remote connection

<h3>Changed</h3>

• Improved selection and setpoint items
• General performance improvements
• Update translations

<h3>Fixed</h3>

• Fixed overlapping label and value
• Fixed a bug where images and charts were not shown
• Fixed some bugs where wrong icon was shown
• Removed useless sitemap refreshes
</en-US>

<de-DE>
<h3>Neu</h3>

• App-Intro
• Neue Designs
• Unterstützung von unterschiedlichen Anmeldedaten für lokalen und entfernten Server

<h3>Änderungen</h3>

• Bessere Darstellung von Selection und Setpoint

<h3>Behoben</h3>
• Überlagerung von Bezeichnungen und Werten bei langen Bezeichnungen behoben
• Ein Fehler wurde behoben, bei dem Diagramme und Bilder nicht angezeigt wurden
• Fehler wurden behoben, bei denen falsche Icons angezeigt wurden
• Unnötiges Nachladen der Sitemap unter bestimmten Bedingungen wurde behoben
</de-DE>

You mostly need more words in german than in english, so I removed some points from the german changelog, e.g. translation (They dont care in germany anyway, since the german translation was nearly complete). @maniac103 Please review. Whats short and good for Fixed overlapping label and value.

[maniac103]

* Neue Themes
* Unterschiedliche Nutzer für lokalen und remote Server werden jetzt unterstützt

I'd write as

* Neue Designs
* Unterstützung von unterschiedlichen Anmeldedaten für lokalen und entfernten Server

Remote-Server instead of entfernten Server would also be ok.

For Fixed overlapping label and value I'd suggest Überlagerung von Bezeichnungen und Werten bei langen Bezeichnungen behoben. I'd also write Unnötiges Nachladen der Sitemap unter bestimmten Bedingungen wurde behoben

[mueller-ma]

@maniac103 Thanks @digitaldan Changelog above is ready for play store.

[digitaldan]

Thanks @mueller-ma ! looks great!

[digitaldan]

Release notes for de-DE should be within the 500 character limit.

Looks like we are still over on the German part.

[mueller-ma]

Remove that part with Unnötiges nachladen...

[digitaldan]

All right, I have the latest apk loaded in the play store , release notes are entered, speak now or forever hold your peace!

[mueller-ma]

... or at least until 2.0.1 :)

[FlorianSW]

Hmm, should we probably wait for #527? :/

[digitaldan]

https://github.com/openhab/openhab.android/releases/tag/2.0.0-PRE-2 is now available with #527, I will need to make one more PR to bump the build number, but this can be tested to verify the fix

[lolodomo]

The menu at top right has now disappeared. That is really cool like that.

[digitaldan]

I have posted https://github.com/openhab/openhab.android/releases/tag/2.0.0 , I will plan on releasing this in a few hours unless I hear otherwise. I will also post an announcement on the community forums. Thanks for everyones help!

[digitaldan]

https://community.openhab.org/t/android-and-ios-2-0-releases

Thanks everyone!

[lolodomo]

With the last minute changes, the translations are now only partial in the preference settings.

[FlorianSW]

@digitaldan Could you remove the bindings and discovery screenshot from the list of screenshots? These functionalities were removed :)