search

openhab / openhab-core

Core framework of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
932 stars 429 forks source link

Error downloading jackson-datatype-jdk8 causes addon installation to fail #4399

Closed mhilbush closed 1 month ago

mhilbush commented 1 month ago

Error downloading mvn:com.fasterxml.jackson.datatype/jackson-datatype-jdk8/2.17.1

In the latest snapshots (4301 in my case), I'm seeing this error, which is causing the installation of all addons to fail.

I didn't see any commits that added this dependency, so maybe it is a new internal dependency of the 2.17.1 version of jackson?

@kaikreuzer @J-N-K Does this jar need to be uploaded to the repo?

mhilbush commented 1 month ago

Am I the only one having this problem? I've not been able to successfully install a snapshot build since 13 September due to this error.

wborn commented 1 month ago

This may be the culprit: https://github.com/openhab/openhab-addons/pull/17412

clinique commented 1 month ago

Am I the only one having this problem? I've not been able to successfully install a snapshot build since 13 September due to this error.

No, you're not alone ;-)

mhilbush commented 1 month ago

@wborn Yes, I see it here. Thanks.

https://github.com/openhab/openhab-addons/pull/17412/files#diff-27cb424f3987ed4ca34b517e65d1861933b41a4c844e7ac332bcadca40e02239R11

Ah, so it only would affect people who have the mqtt binding installed, which I do.

Can someone please upload that jar to the repo? @kaikreuzer

J-N-K commented 1 month ago

Do we really need that bundle? I can't imagine that we really serialize/deserialize something like Optional.

mhilbush commented 1 month ago

I uninstalled the mqtt addon and I'm successfully running the latest snapshot. Thanks @wborn!! I don't know how I missed that PR.

kaikreuzer commented 1 month ago

I do not know, where this dependency was introduced, but I've uploaded it to artifactory - @mhilbush please close the issue, if this issue is resolved by it.

wborn commented 1 month ago

Do we really need that bundle? I can't imagine that we really serialize/deserialize something like Optional.

I don't know if it is actually used. If it's not used the osgiified bundle osgi.bnd should define it as an optional import, see also:

https://github.com/openhab/openhab-addons/pull/17509#discussion_r1788712281

mhilbush commented 1 month ago

I confirmed the problem is resolved.

But would you prefer I leave this issue open until you determine if that dependency is required? Or do you want to open another issue for that?