openhab / openhab-deps-repo

openHAB p2 repository
4 stars 14 forks source link

Bug in javax.mail, replacement impl recommended #1

Open watou opened 8 years ago

watou commented 8 years ago

https://github.com/openhab/openhab/issues/4130 is partly due to a bug in the javax.mail implementation used in both openHAB 1.8.1 and openHAB 2.

This bug is not present in a much more modern implementation of javax.mail. Is it possible to replace the old, buggy JAR with this known working replacement? Otherwise the mail action (and other uses of the bundle in openHAB) will have to imbed this large JAR directly in their respective lib directories in order to overcome the bug.

kaikreuzer commented 8 years ago

@dvanherbergen Can we also include artifacts from Maven repos besides p2 repos?

dvanherbergen commented 8 years ago

I'm not sure, but will have a look.

dvanherbergen commented 8 years ago

The version 1.4.0 in the feature.xml is only used for the runtime in the IDE. In the Karaf based distributions, the more recent version 1.4.4 is included. @watou, was this issue observed only in the IDE or also in the distributions? If only in the IDE, then it may be sufficient to change the runtime to use 1.4.4, so that it matches the distribution.

watou commented 8 years ago

In the Karaf based distributions, the more recent version 1.4.4 is included.

@dvanherbergen, do you have a link to where 1.4.4 is included in the Karaf based distribution? Since 1.4.4 is based on the com.sun.mail and not org.apache.geronimo implementation (if that's the one you are referring to -- the version number history is a mess), then it's liable to work. And the old 1.4.0 version should be fully replaced if possible.

Any hope for openHAB 1 users?

kaikreuzer commented 8 years ago

Well, you can see what is in the distro by checking the path ${openhab.home}/runtime/karaf/system/javax/mail/mail/1.4.4

Any hope for openHAB 1 users?

You should ask this at https://github.com/openhab/openhab/issues/4130 - as this isn't qualified as critical (yet), it does not seem to be a candidate to be included in 1.8.3.

watou commented 8 years ago

${openhab.home}/runtime/karaf/system/javax/mail/mail/1.4.4

Thanks. I didn't know that javax.mail was included in OH2 via Karaf and not explicit packaging via this repo. 1.4.4 is probably good but no time to test atm.

davidgraeff commented 5 years ago

Is this still relevant? ^^