search

openhab / openhab-distro

The binary distribution of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.29k stars 393 forks source link

2.5 distro has grown by 10MB since 2.4 #1009

Closed kaikreuzer closed 3 years ago

kaikreuzer commented 4 years ago

Just wanted to mention this - a while ago, I remember that the distro zip was around 65MB and we have now reached 84MB. I haven't analyzed what has contributed to this, but as the functionality hasn't much changed (apart from the ephemeris feature with an external lib), my expectation would rather be that we should have a similar size as before. In the past, the Karaf upgrades were often the culprit as they brought new versions of bundles, which were then packaged twice in the distro.

@openhab/distro-maintainers, if anyone of you has a good idea or would like to investigate, feel free to do so :-) .

wborn commented 4 years ago

I had a brief look:

So it grew by 9,1MB.

Seems most weight is gained by the change from the MQTT change from paho to hivemq (+1.1M hivemq, +3M netty, +2.3M reactivex). The org.eclipse.paho.client.mqttv3 is only 221,5 kB.

Furthermore there are 2 joda-time versions instead of one (2.2, 2.9.2 (new, +625,6 kB)).

Another big gain is by org.apache.servicemix.bundles.saaj-impl (+2.6M) which is used for supporting JAX-WS on newer Java versions.

kaikreuzer commented 4 years ago

Thanks for the analysis! It is a bit unfortunate that we package the MQTT stuff with the distro although it is only required if the MQTT binding is installed. Maybe we should think about moving the io.transport bundles to the addons repo for openHAB 3...

Furthermore there are 2 joda-time versions instead of one (2.2, 2.9.2 (new, +625,6 kB)).

Would be interesting to check why this came in and if we can remove it again.

Another big gain is by org.apache.servicemix.bundles.saaj-impl

SOAP with attachments...? Do we really need this or is this something optional, which we can exclude?

wborn commented 4 years ago

Maybe we should think about moving the io.transport bundles to the addons repo for openHAB 3

That's indeed worth considering and may make life easier for contributors.

Would be interesting to check why this came in and if we can remove it again.

We specify 2.9.2 for openhab.tp-base and use 2.2 for openhab.tp-swagger-jax-rs-provider.

SOAP with attachments...? Do we really need this or is this something optional, which we can exclude?

It's currently only used by dlinksmarthome. It may also be useful for helios.

pavel-gololobov commented 4 years ago

@kaikreuzer, sorry for the offtopic, but I did not find another method of contacting you. In the 2.5 Release Notes, you forgot to mention the new XMPPClient Binding (https://github.com/openhab/openhab2-addons/tree/master/bundles/org.openhab.binding.xmppclient) binding, which is a replacement for the old 1.x XMPP Action. The old action works not very well. And it could be important to someone. Thank you.

wborn commented 4 years ago

That's good to know! Seems that https://github.com/openhab/openhab2-addons/pull/5433 didn't have the "new binding" label when we generated the release notes.

kaikreuzer commented 4 years ago

@pavel-gololobov Thanks for noticing, I have now manually added this new binding to the release notes as well!

kaikreuzer commented 3 years ago

I guess we can close this.