openhab / openhab-distro

The binary distribution of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.3k stars 393 forks source link

Remove obsolete add-ons during openHAB 4 upgrade #1481

Open kristofejro opened 1 year ago

kristofejro commented 1 year ago

After upgrade from latest 3.4 Milestone Build to 4.0.0.M1 Milestone Build I have some warnings in log during the startup:

2023-03-12 06:45:04.811 [WARN ] [core.karaf.internal.FeatureInstaller] - The transformation add-on 'javascript' does not exist - ignoring it.
2023-03-12 06:46:04.798 [WARN ] [core.karaf.internal.FeatureInstaller] - The transformation add-on 'javascript' does not exist - ignoring it.

In MainUI in Transformation Add-ons section there is no JavaSript transformation add-on listed but when going to karaf console I can see javascript transformation listed:

----------------------------------------------------------------
Pid:            org.openhab.addons
BundleLocation: mvn:org.openhab.core.bundles/org.openhab.core.karaf/4.0.0.M1
Properties:
   automation =
   binding = astro,ipcamera,mail,mqtt,icalendar,http,ntp,networkupstools,zwave,exec,network,openweathermap
   legacy = false
   misc = ,metrics
   package = standard
   persistence = mapdb,influxdb
   remote = true
   service.pid = org.openhab.addons
   transformation = map,jsonpath,regex,javascript
   ui = basic,habpanel
----------------------------------------------------------------

As @J-N-K advised I am opening this issue for future fix.

Fix

If JavaSript transformation add-on is not present in OH4 so it should be removed automatically.

openhab-bot commented 1 year ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-milestone-discussion/145133/37

wborn commented 1 year ago

If you skip OH3 completely and upgrade from OH2 to OH4 there is also https://github.com/openhab/openhab-distro/issues/1172.

wborn commented 1 year ago

It's not just the JS transformation that needs to be removed:

binding:

transformation:

ui:

lolodomo commented 1 year ago

Imperihome also removed: openhab/openhab-addons#15014

lolodomo commented 7 months ago

Another one for OH 4.1: openhab/openhab-addons#15972