search

openhab / openhab-distro

The binary distribution of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.3k stars 391 forks source link

Exclude log format settings file from update #1573

Closed J-N-K closed 1 year ago

J-N-K commented 1 year ago

I propose to remove org.apache.karaf.log.cfg from userdata_sysfiles.lst. There is nothing we need to update on a regular basis and it always overwrites custom log format setting on upgrade. @openhab/distro-maintainers WDYT?

wborn commented 1 year ago

The only issue I see with that is that users that upgrade from OH2 will not be using log4j2.xml

To prevent such issues we could also add some notes on what upgrade paths are supported. Ie. to upgrade from OH n to OH n+2 you first need to upgrade to OH n+1.

That can also become complicated after a while. So some software even have upgrade path tools to compute what versions you need to upgrade through to get to a specific version like GitLab:

https://gitlab-com.gitlab.io/support/toolbox/upgrade-path/

wborn commented 1 year ago

I see I mistook this file for org.ops4j.pax.logging.cfg but there was probably also something that needed to be changed in this file between certain OH versions.

J-N-K commented 1 year ago

The file was changed once in the last five years (to add colored log-messages). I guess we can do the same thing like #1561 if we really need to change it in the future.

wborn commented 1 year ago

Yes that might work as well. We could also add a DEFAULT command for it in the release where the coloring change was made. That way it still gets updated for users upgrading from those older releases.