openhab / openhab-distro

The binary distribution of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.3k stars 394 forks source link

Installation openHAB2 on a Raspberry Pi #231

Closed Ion3 closed 8 years ago

Ion3 commented 8 years ago

Hi,

I think the description here is not corresponding with the Installation on Linux through APT.

It is written:

Curiously, everything was installed as owned by “root”. We need to fix that with the following commands.

sudo chown -hR openhab:openhab /etc/openhab sudo chown -hR openhab:openhab /usr/share/openhab

Are the folders correct? Shouldn't it be something like:

sudo chown -hR openhab:openhab /etc/init.d/openhab2 sudo chown -hR openhab:openhab /usr/share/openhab2

And to add a line break would improve the readability tremendously. :)

Thank you, Timo

kaikreuzer commented 8 years ago

I have fixed the line breaks with https://github.com/openhab/openhab-docs/commit/acdf1717b9ff3fb8c5942975e77e18c16daba29d.

@cniweb Can you comment regarding the folders?

cniweb commented 8 years ago

Oh, yes. The folders: /etc/init.d/openhab2 /usr/share/openhab2 are correct!

kaikreuzer commented 8 years ago

ok, fixed with https://github.com/openhab/openhab-docs/commit/58704a93009573f299be1b908bbfbd9b4dbf017b

Ion3 commented 8 years ago

Still errors: https://github.com/openhab/openhab-docs/commit/acdf1717b9ff3fb8c5942975e77e18c16daba29d

Regard comments in line 46 & 97

Is there a possibility to modify https://github.com/openhab/openhab-docs/blob/gh-pages/installation/rasppi.md directly like in a MediaWiki?

kaikreuzer commented 8 years ago

You should see the "pen" symbol for editing the page:

screen shot 2016-06-27 at 16 41 42
Ion3 commented 8 years ago

For me it is only possible to fork the projekt and "edit the file in [my] fork of this project":

edit_in_your_fork

kaikreuzer commented 8 years ago

If you do so, it should automatically create a PR with your change - does it?

Ion3 commented 8 years ago

It automatically creates a fork:

fork

...but I believe you will not be notified about changes I do there: https://github.com/Ion3/openhab-docs/commit/7c40605be20aa65fe5d782ffc758a85a7df3ab03

kaikreuzer commented 8 years ago

No, but I would have hoped that it is a single click somewhere to create a PR from this change in your fork?

Ion3 commented 8 years ago

I didn't find where to pull the request. I would like to contribute. I did a couple of small things in the openHAB1 Wiki and I will find a way to do so in openHAB2! :-)

kaikreuzer commented 8 years ago

I have just changed some settings on github, could you try again?

Editing should actually open an editor with this header:

screen shot 2016-06-28 at 00 16 19

And this footer:

screen shot 2016-06-28 at 00 16 29
Ion3 commented 8 years ago

Dear Kai,

I tried again, this is what I get:

comparing_changes

It seems to work. I created a pull request as seen above. Is this the right way to do it?

Greetings, Timo

kaikreuzer commented 8 years ago

Is this the right way to do it?

If it works, it is at least not a bad way to do it ;-)

Thanks!

Ion3 commented 8 years ago

Great! Have a good day!