openhab / openhab-distro

The binary distribution of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.3k stars 390 forks source link

installed features not retained in between runtime restarts + features uninstalled right after the start #559

Closed kgoderis closed 7 years ago

kgoderis commented 7 years ago

Again, on build 1063, It seems the runtime for some reason does not retain the list of installed bundles in between restarts, and in terms of bindings, only the those installed in the add-on directory are correctly installed. Everything that is in addons.cfg is trashed at startup. See below an excerpt of what is happening to the Tesla binding (defined in addons.cfg):

[Note, I come from a build # in the low 940's, so I missed all the changes around bundle resolving and so forth - if I missed something essential, pls do not slap my hands ;-) ]

  1. It picks up addons.cfg and seems to install these features

2017-10-17 21:59:43.471 [DEBUG] [core.karaf.internal.FeatureInstaller] - Installed 'openhab-voice-marytts, openhab-binding-network, openhab-binding-freeswitch1, openhab-ui-habpanel, openhab-binding-lifx, openhab-action-pushover, openhab-binding-tesla, openhab-transformation-map, openhab-binding-hdanywhere, openhab-binding-rme, openhab-misc-marketplace, openhab-binding-miele, openhab-transformation-xslt, openhab-binding-systeminfo, openhab-ui-paper, openhab-binding-samsungtv, openhab-binding-http1, openhab-binding-sonos, openhab-transformation-jsonpath, openhab-binding-oceanic, openhab-persistence-rrd4j, openhab-ui-basic, openhab-binding-ntp, openhab-action-mail, openhab-binding-astro'

  1. Then the binding gets trashed

2017-10-17 21:59:44.079 [DEBUG] [ig.xml.osgi.XmlDocumentBundleTracker] - Releasing the XmlDocumentProvider for module 'org.openhab.binding.tesla'. 2017-10-17 21:59:44.080 [DEBUG] [re.internal.service.ReadyServiceImpl] - Removed ready marker esh.xmlThingTypes=org.openhab.binding.tesla 2017-10-17 21:59:44.080 [DEBUG] [re.internal.service.ReadyServiceImpl] - Removed ready marker esh.xmlConfig=org.openhab.binding.tesla 2017-10-17 21:59:44.081 [DEBUG] [ig.xml.osgi.XmlDocumentBundleTracker] - Releasing the XmlDocumentProvider for module 'org.openhab.binding.tesla'. 2017-10-17 21:59:44.081 [DEBUG] [re.internal.service.ReadyServiceImpl] - Removed ready marker esh.xmlBindingInfo=org.openhab.binding.tesla 2017-10-17 21:59:44.081 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent STOPPING - org.openhab.binding.tesla 2017-10-17 21:59:44.081 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent STOPPED - org.openhab.binding.tesla

2017-10-17 21:59:44.273 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent UNRESOLVED - org.openhab.binding.tesla 2017-10-17 21:59:44.275 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent UNINSTALLED - org.openhab.binding.tesla

  1. Then I have to feature:install it again by hand in the console

2017-10-17 22:06:25.596 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent INSTALLED - org.openhab.binding.tesla 2017-10-17 22:06:25.616 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent RESOLVED - org.openhab.binding.tesla 2017-10-17 22:06:25.617 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent STARTING - org.openhab.binding.tesla 2017-10-17 22:06:25.618 [DEBUG] [ig.xml.osgi.XmlDocumentBundleTracker] - Reading the XML document '/ESH-INF/thing/models.xml' in module 'org.openhab.binding.tesla'... 2017-10-17 22:06:25.623 [DEBUG] [org.openhab.binding.tesla ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.io.console.extensions.ConsoleCommandExtension}={component.name=org.openhab.binding.tesla.command.TeslaCommandExtension, component.id=226, service.id=346, service.bundleid=425, service.scope=bundle} - org.openhab.binding.tesla 2017-10-17 22:06:25.626 [DEBUG] [ome.core.thing.internal.ThingManager] - Thing handler factory 'TeslaHandlerFactory' added 2017-10-17 22:06:25.627 [DEBUG] [.thing.internal.GenericThingProvider] - ThingHandlerFactory added org.openhab.binding.tesla.internal.TeslaHandlerFactory@41e7d4e7 2017-10-17 22:06:25.627 [DEBUG] [org.openhab.binding.tesla ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.core.thing.binding.ThingHandlerFactory}={component.name=org.openhab.binding.tesla.internal.TeslaHandlerFactory, component.id=227, service.id=347, service.bundleid=425, service.scope=bundle} - org.openhab.binding.tesla 2017-10-17 22:06:25.628 [DEBUG] [org.openhab.binding.tesla ] - BundleEvent STARTED - org.openhab.binding.tesla 2017-10-17 22:06:25.628 [DEBUG] [re.internal.service.ReadyServiceImpl] - Added ready marker esh.xmlConfig=org.openhab.binding.tesla 2017-10-17 22:06:25.628 [DEBUG] [ig.xml.osgi.XmlDocumentBundleTracker] - Reading the XML document '/ESH-INF/binding/binding.xml' in module 'org.openhab.binding.tesla'... 2017-10-17 22:06:25.629 [DEBUG] [re.internal.service.ReadyServiceImpl] - Added ready marker esh.xmlBindingInfo=org.openhab.binding.tesla

kubawolanin commented 7 years ago

I'm experiencing this as well. Adding @kaikreuzer Currently I'm on distro 1064 and here are my steps to reproduce this bug.

Platform: Windows 10, Java 1.8.0_144

  1. Place openhab-addons-2.2.0-SNAPSHOT.kar file in the /addons/ (or run kar:install file:///C:/oh/openhab-addons-2.2.0-SNAPSHOT.kar)
  2. Modify /conf/services/addons.cfg with extensions of your choice
  3. start.bat (with or without Admin privileges) and wait for Karaf to be up and running
  4. bundle:list -> Showing ~462 bundles

Observed result: After a short time period running bundle:list again results in listing 175 bundles.

Expected result: List of bundles is retained.

Workaround: Interestingly if I make any change in /conf/services/addons.cfg and save the file while OH server is running, the list of bundles goes back to normal 🤔

kgoderis commented 7 years ago

@kubawolanin @kaikreuzer Even the bundles that are installed by default, I think, like PaperUI, and that are listed explicitly in the addons.cfg are uninstalled. Would this have to do with the .cfg Model/parsing and/or .cfg Directory Watcher?

Strangly enough I have not seen complaints about this on the OH2 Community Forum, but seems to be of a critical bug from a user perspective.

kaikreuzer commented 7 years ago

Isn't this a duplicate of https://github.com/openhab/openhab-distro/issues/519? At least for @kubawolanin it is as he is using the KAR. @kgoderis can you confirm that you are using the KAR as well? If so, please close this issue.

kgoderis commented 7 years ago

@kaikreuzer I am using the KAR as well, but I have remote=true set for the Legacy bindings