openhab / openhab-docker

Repository for building Docker containers for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
209 stars 128 forks source link

adding ssh to container #268

Closed Homer-Sim closed 4 years ago

Homer-Sim commented 4 years ago

Hello,

I am not so familiar with Dockerfile to do it by my own. I need for executing commands on a remote RPi the ssh within the container. Each time updating I have to install it manually. Would it be an idea to add ssh from scratch?

Thanks

wborn commented 4 years ago

It seems to add 30 MB to the images which is quite a lot. If we'd add every requested package we'll end up with Docker images having the size of a full blown OS.

Each package that gets added potentially also makes the image less secure because it can have its own vulnerabilities.

Instead of creating and having to maintain your own image, you can also add a script that installs it when the container is started.

ldrrp commented 4 years ago

I dont think its needed honestly, you can just ssh from the host machine perfectly fine with default password habopen.