search

openhab / openhab-docker

Repository for building Docker containers for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
212 stars 128 forks source link

2.5.x snapshot build? #272

Closed martinvw closed 4 years ago

martinvw commented 4 years ago

Hello,

Is there already a 2.5.x snapshot build?

Currently, 3.0.0 is not yet stable enough so it would be great to have a 2.5.x snapshot build.

Thanks!

cc: @wborn :-)

wborn commented 4 years ago

AFAIK further updates are provided by KAR files and not new distros.

See: https://github.com/orgs/openhab/teams/maintainers/discussions/2?from_comment=49#discussion-2-comment-49

martinvw commented 4 years ago

So that makes sense because the core will not be updated and can use the newest addons :-)

jsetton commented 4 years ago

Any chance to get more information related to this? I am running the latest stable 2.5.1 docker image and I can't use the latest 2.5.2-snapshot addons with this image, while they can be downloaded from the Jenkins repository. It seems to me a 2.5.x-snapshot build should be available.

kaikreuzer commented 4 years ago

No, releases will only use released versions of add-ons, no snapshots.

jsetton commented 4 years ago

So, how do we test the 2.5.2-snapshot add-ons? My point was to have 2.5.x-snapshot docker image available. Not to use 2.5.2-snapshot add-ons with 2.5.1 release.

martinvw commented 4 years ago

I do believe we might be able to provide an 2.5.x-SNAPSHOT build which contains the stable core and has the proper reference to the snapshot repo such as we discussed @ FOSDEM.

@kaikreuzer would you be okay with such a solution?

kaikreuzer commented 4 years ago

You mean a distro build? No, I don't think it makes sense to do snapshot builds, while never intending to do a release build of it. Why not simply edit the repo url manually, when people want to test snapshot add-ons?

martinvw commented 4 years ago

No I mean a docker build. Thus the stable distro with the changed repo url wrapped as a docker image.

jsetton commented 4 years ago

Either this or expose an environment variable that would be used by the update script to update the add-ons locations to use the latest 2.5 snapshot add-ons KAR files.

kaikreuzer commented 4 years ago

No I mean a docker build.

Then don't ask me, but decide together with the @openhab/docker-maintainers :-)

wborn commented 4 years ago

I would prefer to keep it simple and add an image using the 2.5.2-SNAPSHOT distro (even though it may never be released).

Rationale:

jsetton commented 4 years ago

@wborn just a thought, if 2.5.2-SNAPSHOT docker image is added, should it be considered as the default snapshot image over 3.0.0-SNAPSHOT until the latter is usable?

wborn commented 4 years ago

I think it's quite subjective to determine when 3.0.0-SNAPSHOT is usable. It may never be usable for OH1 add-on users.

jsetton commented 4 years ago

It may never be usable for OH1 add-on users.

That's actually a fact 😄 My comment was more oriented on some of the major functionalities, such as persistence, that still need to be ported over. Preventing most users from running 3.0.0-SNAPSHOT right now. Anyway, this was just a thought.

kaikreuzer commented 4 years ago

using the 2.5.2-SNAPSHOT distro

Ah, I only noticed now that this is still built - I was actually believing that the build only produces the add-ons artifacts now as that was the plan. But maybe it is easier to keep the distro after all, even if it means that the 2.5.2 release will be identical to 2.5.1. But it probably cause less confusion, if the download page shows the distro of the same latest version as we ship the add-ons.

jsetton commented 4 years ago

@wborn Thanks for merging the change. I noticed the 2.5.2-snapshot-alpine tag is not available while all the associated 2.5.2-SNAPSHOT tags are.

$ docker pull openhab/openhab:2.5.2-snapshot-alpine
Error response from daemon: manifest for openhab/openhab:2.5.2-snapshot-alpine not found
wborn commented 4 years ago

Thanks for spotting that @jsetton! It seems to have been missing for a while :blush: and should be fixed with https://github.com/openhab/openhab-docker/pull/279.

wborn commented 4 years ago

Seems like the alpine images still fail to deploy because the Alpine v3.11 armhf image is missing :disappointed:

See: https://github.com/multiarch/alpine/issues/30

So maybe it's best to downgrade back to v3.10 if that still works.

jsetton commented 4 years ago

As far as I can see, only 2.5.2-snapshot-alpine tag is missing from Docker hub. All the other alpine tags have been generated in the last update. That's very odd.

wborn commented 4 years ago

Those tags are a couple of weeks old and were generated when Alpine v3.10 was still used.

I've downgraded the version with https://github.com/openhab/openhab-docker/pull/280 and it will now properly fail the build when commands fail. That helps a lot because it also showed that the OH 3.0.0-SNAPSHOT build fails on Alpine because there is no openjdk11 package for armhf (https://github.com/openhab/openhab-docker/issues/281). :-/

jsetton commented 4 years ago

I was able to pull the 2.5.2-snapshot-alpine docker image and is working great. Thanks!

kaikreuzer commented 4 years ago

But maybe it is easier to keep the distro after all, even if it means that the 2.5.2 release will be identical to 2.5.1. But it probably cause less confusion, if the download page shows the distro of the same latest version as we ship the add-ons.

@wborn FYI, I am keeping the distro artifact in place with the current 2.5.2 build, so you can also provide docker images for the release version (as you do for the snapshots).

wborn commented 4 years ago

Thanks! I've updated the build for the new stable/snapshot versions with #282.