openhab / openhab-docker

Repository for building Docker containers for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
211 stars 128 forks source link

Build images using Docker CE 19.03 and BuildKit #293

Closed wborn closed 4 years ago

wborn commented 4 years ago

Switching to BuildKit has many advantages:

There is now a single Dockerfile per image instead of one for each architecture. BuildKit does not provide a way to also generate tags containing architectures so these tags will no longer be generated.

Furthermore the Travis configuration has been updated so it will also automatically sync the README.md to Docker Hub.

Fixes #184


This change is Reviewable

wborn commented 4 years ago

Are you OK with these changes @cniweb?

wborn commented 4 years ago

I'll proceed with merging this. Feel free to make any comments on this afterwards @cniweb.

bwosborne2 commented 4 years ago

Why was this breaking change made on a stable release and not even mentioned in the Release notes?? My Docker install script that worked fine in 2.5.3 was broken when I tried with 2,5,6, There were no breaking changes listed in the intervening Release Notes.