openhab / openhab-docs

This repository contains the documentation for openHAB.
https://www.openhab.org/docs/
Other
268 stars 682 forks source link

[airgradient] Add logo for recently added binding #2296

Closed austvik closed 1 month ago

austvik commented 1 month ago

[airgradient] Add logo for recently added binding

netlify[bot] commented 1 month ago

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
Latest commit 15f587a16f026c6b97deacec4b9984ff8a0b0a02
Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/664251b7cf71020008e78212
Deploy Preview https://deploy-preview-2296--openhab-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jlaur commented 1 month ago

@austvik - do you have an SVG version of the logo that could be used instead? See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

austvik commented 1 month ago

Great! Added svg now.

I looked at this page where it wasn't mentioned as a possibility, but the original was svg so this is an improvement https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

austvik commented 1 month ago

I have checked the error and do not see how it is relevant for adding a .svg file: "Error: developers/bindings/thing-xml.md:930:189 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]"

stefan-hoehn commented 1 month ago

The error doesn't come from your PR - it is probably from somewhere else. I will merge anyway.

austvik commented 1 month ago

Thank you!