openhab / openhab-docs

This repository contains the documentation for openHAB.
https://www.openhab.org/docs/
Other
274 stars 692 forks source link

Favicon has white background #445

Closed mueller-ma closed 7 years ago

mueller-ma commented 7 years ago

and I dont know why. openhab-docs/_iconsets/classic/icons/favicon.ico seems to have a transparent background

ThomDietrich commented 7 years ago

Good question, I've thought about this as well. The reason might be, that the background of a browser tab is not known to us and colors might mix poorly. Just think about this firefox addon as an example: https://addons.mozilla.org/de/firefox/addon/colorfultabs

Let's learn from others:

grafik

Seems like a few icons have white backgrounds (e.g. google, owncloud, Wikipedia) while others do not (e.g. GitHub), some icons just do not have empty space to fill (e.g. Facebook, Firefox).

Interestingly the openHAB community has a transparent icon.

I'm seeing four solutions to this:

  1. Leave as is
  2. Remove the surrounding white but leave the insides
  3. Remove the white background completely
  4. Go with the new android app icon (That was a surprise to me)

@kaikreuzer @BClark09

mueller-ma commented 7 years ago

I have the firefox dark theme and the github icon is very bad readable. IMO the android icon might not fit perfectly because of the cast shadow which is very android like. We should wait for https://community.openhab.org/t/openhab-logo-update/31242.

BClark09 commented 7 years ago

I have the firefox dark theme and the github icon is very bad readable.

Also these sorts of icons (when you bookmark a page for example) get rather lost in other UIs for example in some versions of IOS, where any transparency is filled with black.

Out of the first three, two would be most appropriate although it'd probably be cleaner to just round off the four corners instead of trying to wrap round the icon.

Confectrician commented 7 years ago

Is this still up to date with our new logo? If not, the issue could be closed.

ThomDietrich commented 7 years ago

Depends. The new logo is now once again without the white filling (option 2). Do we want to leave it like this?

Confectrician commented 7 years ago

My opinion:

I think in most cases the actual logo will fit fine, especially because it is some more minimalistic with thinner lines compared to the old one. I would leave it like it is for now.

kaikreuzer commented 7 years ago

I created it with the transparent background, but also noticed that on dark backgrounds (and people use all different kinds of skins) it is difficult to see. So I have already updated the community forum favicon this way:

bildschirmfoto 2017-10-26 um 10 52 06

I think this is better, so I would also suggest this for the docs and the webapps. I can create PRs in the next days.

ThomDietrich commented 7 years ago

Exactly my point and I would also go that way. Please do ;)

mueller-ma commented 7 years ago

Thanks @kaikreuzer

kaikreuzer commented 7 years ago

All done!

screen shot 2017-10-27 at 18 09 44

(also updated the favicon in the Classic/Basic/Paper/Dashboard)