openhab / openhab-google-assistant

openHAB Google Assistant: Actions on Google for openHAB
Eclipse Public License 2.0
176 stars 86 forks source link

Add deploy documentation step #410

Closed jsetton closed 1 year ago

jsetton commented 1 year ago

As highlighted in this forum post, the Google Assistant live documentation is not getting updated when a new release is deployed.

This PR adds support for the fetch external docs workflow added last year to the openhab-docs repository to address this specific issue.

The DOCS_REPO_ACCESS_TOKEN secret environment variable should already be defined for this repository. If not, @Confectrician should be able to add it.

michikrug commented 1 year ago

@Confectrician would you be able to add the DOCS_REPO_ACCESS_TOKEN to this repo?

Confectrician commented 1 year ago

I think @kaikreuzer did this for the other repositories, since i have no access over there and i also hove none to do it here. I will reach out to him to do so. 🙂

kaikreuzer commented 1 year ago

Let me figure out what I need to do and I'll be of your assistance!

kaikreuzer commented 1 year ago

I have added a DOCS_REPO_ACCESS_TOKEN as a repository secret. Hope this helps!

Confectrician commented 1 year ago

The releas workflow seems to have skipped the docs step.

Are you sure about the event name in the workflow condition?

michikrug commented 1 year ago

@kaikreuzer unfortunately the action states: Bad credentials

https://github.com/openhab/openhab-google-assistant/actions/runs/3431936388/jobs/5720650525

michikrug commented 1 year ago

The releas workflow seems to have skipped the docs step.

Are you sure about the event name in the workflow condition?

No, all fine. It was skipped for the Tag but done for the Published Release. Unfortunately with an error as stated above.

kaikreuzer commented 1 year ago

@michikrug Looks better now! https://github.com/openhab/openhab-google-assistant/actions/runs/3431936388/jobs/5726268941

Confectrician commented 1 year ago

Looks good. I have an open openhabian pr (the workflow file had a wrong part yesterday which is already fixed) in the docs repository.

With the fixed workflow file it should then open a valid google asisstent doc pr.

michikrug commented 1 year ago

Great. Thanks for your support.