Closed florian-h05 closed 2 years ago
Thanks florian, i think this is a great idea. If you can update the PR to resolve conflicts I'll take a look at it locally.
@digitaldan All conflicts are resolved!
@digitaldan Have you had a look at it yet?
Hey @florian-h05 i'm looking at oh stuff today, i'll give this a spin today.
So this looks good to me! Lets get #99 and #101 merged fist so we don't have conflicts and then we can merge this one.
@digitaldan Before this gets merged, I will rebase from main and re-apply the code formatting to resolve all conflicts.
Ok, i think we are ready if you want to rebase and re-apply.
@digitaldan I rebased and reapplied the linting, ready to go now!
👍
Add
standardx
to enforce consistent codestyleDescription
This PR adds
standardx
(you might also know the JavaScriptstandard
orsemistandard
libraries) to enforce a consistent codestyle. I decided forstandardx
as it is based onstandard
, which is widely used, and is also highly customizable as it is based oneslint
. The codestyle is checked every timenpm test
runs, therefore it would also apply to the jobs that run on a PR.My motivation for this was, that the codestyle here often differs, e.g. the intendation. I have applied the codestyle to all JavaScript files.
Testing
I have never experienced any problems with the automated fix function of StandardJS and currently I am testing this PR on my system. But as I do not use everything the library provides, maybe somebody could also test it.
You can find the packed tarball here: https://1drv.ms/u/s!Al8cKKxosMjV7goODVlLcCvpB-aM?e=lDM9PJ
@digitaldan Please let me know what you think about that addition / change.