Closed florian-h05 closed 1 year ago
@digitaldan Can you review?
For future fixes without breaking changes, do you want to review them or is it okay for you if I merge them after I tested them?
Hi @digitaldan, there should be no need to test, I tested all ItemHistory methods and all worked.
Regarding the README, I removed the section because it needs manual updating every time there is a change (shouldn’t be often), but you’ve got a point that this probably should be in the docs. Sometimes it would be helpful to have the opinion of a normal user on such questions. I’ll add the ItemHistory Actions back to the README.
Fixes #157. Fixes #156.
Description
This PR adds the missing xxxBetween methods from the
PersistenceExtensions
and enables type defintions foritems.getItem('MyItem').history
.The docs for ItemHistory are removed from the README, as they require manual update, but instead the JSDoc is linked.
Testing
You can install this version with
npm i git+https://github.com/florian-h05/openhab-js.git#itemhistory-improvements
.All
ItemHistory
methods are tested and working.I used the following script for testing: