Closed florian-h05 closed 1 year ago
@digitaldan @jpg0 @rkoshak Can you please review? This is urgent, because we should get this merged before the sixth milestome and the feature freeze comes on Sunday evening.
You only need to review cache.js
and the README changes, the rest is not so important.
@digitaldan @jpg0 If you want to give your review, please do it until this evening (+11 hours from now). After this, I'll merge to get this in before the feature freeze; I've already got two reviews so it is not unreviewed.
LGTM!
Fixes #184.
Reference https://github.com/openhab/openhab-core/pull/2887. Reference https://github.com/openhab/openhab-core/pull/3204.
Description
This implements:
cache
:private
property tocache
to allow access to the private cacheshared
property tocache
to allow access to the shared cacheUnit test is updated to test the
JSCache
class instead of the exported methods of thecache
namespace, because testing the exported methods for each case is quite complex and given the fact that the compatibility layer will be removed at some time, I decided to not take that effort.Testing
The functionality of
JSCache
is tested by the Jest unit test, the exports are tested by me.