openhab / openhab-js

openHAB JavaScript Library for JavaScript Scripting Automation
https://www.openhab.org/addons/automation/jsscripting/
Eclipse Public License 2.0
38 stars 31 forks source link

[Quantity] Rename comparison methods & Add docs #211

Closed florian-h05 closed 1 year ago

florian-h05 commented 1 year ago

Follow-up to #206.

Description

florian-h05 commented 1 year ago

@rkoshak Can you please have a look at this? You are always good at reviewing docs.

florian-h05 commented 1 year ago

@rkoshak @stefan-hoehn Can you please have a look at the current version?

stefan-hoehn commented 1 year ago

LGTM now

florian-h05 commented 1 year ago

@stefan-hoehn Let’s wait for Rich and see if he’s happy with the changes.

rkoshak commented 1 year ago

LGTM. Thanks! I'm looking forward to having this support!

florian-h05 commented 1 year ago

It is actually already included in the current 3.2.0 library release, but it’s not documented there. I will try to publish a new version with the changed method names and the refactored metadata API soon, but before I want to do some other improvements.

Anyway, I wish you all a good new year (that begins at different times for us) 🎆